Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: chrome/browser/history/scored_history_match.h

Issue 77453007: Omnibox: Make HistoryURL Highlight Titles like HistoryQuick Provider (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: highlight exact input title too Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/scored_history_match.h
diff --git a/chrome/browser/history/scored_history_match.h b/chrome/browser/history/scored_history_match.h
index fbd8d47e1d7ec29c6dd41253a6ecf7726411b223..d7cab3ccfe33bb0b63c35cf784762b19c1b910ed 100644
--- a/chrome/browser/history/scored_history_match.h
+++ b/chrome/browser/history/scored_history_match.h
@@ -63,6 +63,14 @@ class ScoredHistoryMatch : public history::HistoryMatch {
const TermMatches& title_matches() const { return title_matches_; }
bool can_inline() const { return can_inline_; }
+ // Returns |term_matches| after removing all matches that are not at a
Mark P 2013/11/22 02:26:32 This is a simple move of this function from privat
+ // word break that starts after position |start_pos|. If |start_pos| is
+ // string::npos, does no filtering and simply returns |term_matches|.
+ static TermMatches FilterTermMatchesByWordStarts(
+ const TermMatches& term_matches,
+ const WordStarts& word_starts,
+ const size_t start_pos);
+
private:
friend class ScoredHistoryMatchTest;
@@ -82,15 +90,6 @@ class ScoredHistoryMatch : public history::HistoryMatch {
const string16& cleaned_up_url,
const RowWordStarts& word_starts);
- // Helper function for GetTopicalityScore().
- // Returns |term_matches| after removing all matches that are not at a
- // word break that starts after position |start_pos|. If |start_pos| is
- // string::npos, does no filtering and simply returns |term_matches|.
- static TermMatches FilterTermMatchesByWordStarts(
- const TermMatches& term_matches,
- const WordStarts& word_starts,
- const size_t start_pos);
-
// Precalculates raw_term_score_to_topicality_score, used in
// GetTopicalityScore().
static void FillInTermScoreToTopicalityScoreArray();

Powered by Google App Engine
This is Rietveld 408576698