Omnibox: Make HistoryURL Highlight Titles like HistoryQuick Provider

chrome/browser/autocomplete/history_provider.h

Index: chrome/browser/autocomplete/history_provider.h
diff --git a/chrome/browser/autocomplete/history_provider.h b/chrome/browser/autocomplete/history_provider.h
index 6be0e2b461761b470f57235570f05d75cf184cf5..2d9b088e225f289661d441b58f064cd6cff1d381 100644
--- a/chrome/browser/autocomplete/history_provider.h
+++ b/chrome/browser/autocomplete/history_provider.h
@@ -7,6 +7,7 @@
 
 #include "base/compiler_specific.h"
 #include "chrome/browser/autocomplete/autocomplete_provider.h"
+#include "chrome/browser/history/in_memory_url_index_types.h"

[Peter Kasting, 2013/11/23 02:15:36]

Nit: Forward-declare TermMatches instead of #including this

[Mark P, 2013/11/25 19:59:16]

I tried.  I could not manage to forward declare a typedef.  I don't think it's
possible without (forward) declaring the underlying type, and declaring the
underlying type means means writing:
---
struct TermMatch;
typedef std::vector<TermMatch> TermMatches;
---
and that seems worse to me than using the #include.  (What if someone changes
the std::vector to a different container type? I don't want it used in separate
ways in two places.)

 
 class AutocompleteInput;
 struct AutocompleteMatch;
@@ -53,6 +54,13 @@ class HistoryProvider : public AutocompleteProvider {
   // |input.prevent_inline_autocomplete()| is true or the input text contains
   // trailing whitespace.
   bool PreventInlineAutocomplete(const AutocompleteInput& input);
+
+  // Fill and return an ACMatchClassifications structure given the term

[Mark P, 2013/11/22 02:26:32]

This was moved here from history_quick_provider.h.

+  // matches (|matches|) to highlight where terms were found.

[Peter Kasting, 2013/11/23 02:15:36]

Nit: "...given the |matches| to highlight." is probably sufficient.

[Mark P, 2013/11/25 19:59:16]

Done.

+  static ACMatchClassifications SpansFromTermMatch(
+      const history::TermMatches& matches,
+      size_t text_length,
+      bool is_url);
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_HISTORY_PROVIDER_H_