Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 77453007: Omnibox: Make HistoryURL Highlight Titles like HistoryQuick Provider (Closed)

Created:
7 years, 1 month ago by Mark P
Modified:
7 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su, msw
Visibility:
Public.

Description

Omnibox: Make HistoryURL Highlight Titles like HistoryQuick Provider Previously HistoryURL provider would highlight page titles by searching for the first occurrence of the input term and highlighting it. This was case sensitive. Now HistoryURL provider highlights page titles in the same way as HistoryQuick provider: it normalizes the title (i.e., lowercases it) and highlights all occurrences that appear at word breaks. TBR=sky BUG=318329 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237504

Patch Set 1 #

Patch Set 2 : highlight exact input title too #

Patch Set 3 : highlight exact input title too #

Total comments: 20

Patch Set 4 : no changes #

Patch Set 5 : rebase #

Patch Set 6 : Peter's comments #

Patch Set 7 : remove unnecessary comment #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -84 lines) Patch
M chrome/browser/autocomplete/history_provider.h View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_provider.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 1 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.h View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 2 3 4 5 6 3 chunks +23 lines, -8 lines 0 comments Download
M chrome/browser/history/scored_history_match.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/history/scored_history_match.cc View 1 2 3 4 5 6 7 2 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Mark P
https://codereview.chromium.org/77453007/diff/60001/chrome/browser/autocomplete/history_provider.h File chrome/browser/autocomplete/history_provider.h (right): https://codereview.chromium.org/77453007/diff/60001/chrome/browser/autocomplete/history_provider.h#newcode58 chrome/browser/autocomplete/history_provider.h:58: // Fill and return an ACMatchClassifications structure given the ...
7 years, 1 month ago (2013-11-22 02:26:31 UTC) #1
Mark P
Peter, please take a look. No hurry. thanks, mark
7 years, 1 month ago (2013-11-22 02:26:56 UTC) #2
Peter Kasting
The mail.g question below is the only serious one. https://codereview.chromium.org/77453007/diff/60001/chrome/browser/autocomplete/history_provider.h File chrome/browser/autocomplete/history_provider.h (right): https://codereview.chromium.org/77453007/diff/60001/chrome/browser/autocomplete/history_provider.h#newcode10 chrome/browser/autocomplete/history_provider.h:10: ...
7 years, 1 month ago (2013-11-23 02:15:35 UTC) #3
Mark P
Please take another look. --mark https://codereview.chromium.org/77453007/diff/60001/chrome/browser/autocomplete/history_provider.h File chrome/browser/autocomplete/history_provider.h (right): https://codereview.chromium.org/77453007/diff/60001/chrome/browser/autocomplete/history_provider.h#newcode10 chrome/browser/autocomplete/history_provider.h:10: #include "chrome/browser/history/in_memory_url_index_types.h" On 2013/11/23 ...
7 years ago (2013-11-25 19:59:16 UTC) #4
Peter Kasting
https://codereview.chromium.org/77453007/diff/60001/chrome/browser/autocomplete/history_url_provider.cc File chrome/browser/autocomplete/history_url_provider.cc (right): https://codereview.chromium.org/77453007/diff/60001/chrome/browser/autocomplete/history_url_provider.cc#newcode1102 chrome/browser/autocomplete/history_url_provider.cc:1102: // if it's multiple terms such as mail.g. That ...
7 years ago (2013-11-26 02:15:36 UTC) #5
Mark P
Did you have any other comments from this last batch of changes, or was this ...
7 years ago (2013-11-26 20:08:15 UTC) #6
Peter Kasting
LGTM
7 years ago (2013-11-26 20:09:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/77453007/280001
7 years ago (2013-11-26 20:43:16 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=229239
7 years ago (2013-11-26 23:17:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/77453007/300001
7 years ago (2013-11-27 00:14:01 UTC) #10
commit-bot: I haz the power
7 years ago (2013-11-27 04:07:49 UTC) #11
Message was sent while issue was closed.
Change committed as 237504

Powered by Google App Engine
This is Rietveld 408576698