Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 774483004: Revert of Turn on stack use-after-return detection in non-official ASan builds. (Closed)

Created:
6 years ago by Alexander Potapenko
Modified:
6 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn on stack use-after-return detection in non-official ASan builds. (patchset #5 id:70003 of https://codereview.chromium.org/760503002/) Reason for revert: This broke some layout tests, see http://crbug.com/438499 Original issue's description: > Turn on stack use-after-return detection in non-official ASan builds. > > BUG=390117 > R=scherkus@chromium.org > TBR=earthdok@chromium.org,thakis@chromium.org > > Committed: https://crrev.com/136dc0bf75f9be7ae86c336005279b6dde4dee46 > Cr-Commit-Position: refs/heads/master@{#306429} TBR=earthdok@chromium.org,thakis@chromium.org,scherkus@chromium.org NOTREECHECKS=true NOTRY=true BUG=390117 Committed: https://crrev.com/ec036d3de01dd6c809baad7558ffbb4986fa1822 Cr-Commit-Position: refs/heads/master@{#306618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -25 lines) Patch
M base/debug/proc_maps_linux_unittest.cc View 2 chunks +10 lines, -20 lines 0 comments Download
M build/sanitizers/sanitizer_options.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexander Potapenko
Created Revert of Turn on stack use-after-return detection in non-official ASan builds.
6 years ago (2014-12-03 16:21:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774483004/1
6 years ago (2014-12-03 16:22:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-03 16:23:17 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-03 16:24:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec036d3de01dd6c809baad7558ffbb4986fa1822
Cr-Commit-Position: refs/heads/master@{#306618}

Powered by Google App Engine
This is Rietveld 408576698