Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 774413002: Update from https://crrev.com/306724 (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
Reviewers:
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Update from https://crrev.com/306724 This one actually contains the BUILD.gn reformats and updates net_sql.patch and skia_build.patch to apply. Committed: https://chromium.googlesource.com/external/mojo/+/447ca5e902e7f80b24ba0d4826aaebf34a4f8203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1084 lines, -766 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M base/allocator/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M base/process/kill.h View 2 chunks +3 lines, -4 lines 0 comments Download
M base/process/kill_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/process/kill_posix.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/process/kill_win.cc View 5 chunks +15 lines, -12 lines 0 comments Download
M base/process/launch.h View 2 chunks +4 lines, -2 lines 0 comments Download
M base/process/launch_win.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M base/process/process_util_unittest.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M build/android/pylib/base/test_instance_factory.py View 1 chunk +10 lines, -3 lines 0 comments Download
A build/android/pylib/gtest/gtest_test_instance.py View 1 chunk +137 lines, -0 lines 0 comments Download
M build/config/android/config.gni View 2 chunks +6 lines, -12 lines 0 comments Download
M build/config/android/internal_rules.gni View 3 chunks +12 lines, -4 lines 0 comments Download
M build/config/android/rules.gni View 2 chunks +4 lines, -3 lines 0 comments Download
M build/go/rules.gni View 2 chunks +6 lines, -2 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 2 chunks +2 lines, -4 lines 0 comments Download
M build/secondary/third_party/icu/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M build/secondary/tools/grit/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M build/secondary/tools/grit/repack.gni View 1 chunk +3 lines, -1 line 0 comments Download
M build/toolchain/android/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 5 chunks +23 lines, -25 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 4 chunks +34 lines, -39 lines 0 comments Download
M build/toolchain/nacl/BUILD.gn View 2 chunks +4 lines, -8 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 5 chunks +22 lines, -24 lines 0 comments Download
M build/util/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 3 chunks +55 lines, -0 lines 0 comments Download
M cc/surfaces/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 3 chunks +18 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M crypto/BUILD.gn View 3 chunks +8 lines, -5 lines 0 comments Download
M gpu/BUILD.gn View 2 chunks +3 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 4 chunks +16 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/config/BUILD.gn View 3 chunks +6 lines, -8 lines 0 comments Download
M mojo/tools/roll/net_sql.patch View 3 chunks +16 lines, -16 lines 0 comments Download
M mojo/tools/roll/skia_build.patch View 1 chunk +15 lines, -12 lines 0 comments Download
M net/BUILD.gn View 23 chunks +319 lines, -310 lines 0 comments Download
M net/android/BUILD.gn View 3 chunks +4 lines, -3 lines 0 comments Download
M net/base/registry_controlled_domains/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
M net/third_party/nss/ssl/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download
M sandbox/linux/BUILD.gn View 7 chunks +6 lines, -9 lines 0 comments Download
M sdch/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M skia/BUILD.gn View 13 chunks +135 lines, -136 lines 0 comments Download
M testing/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/android/junit/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M testing/perf/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/cython/rules.gni View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/yasm/BUILD.gn View 11 chunks +33 lines, -11 lines 0 comments Download
M third_party/yasm/yasm_assemble.gni View 1 chunk +3 lines, -1 line 0 comments Download
M tools/android/forwarder2/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/android/md5sum/BUILD.gn View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/generate_library_loader/generate_library_loader.gni View 3 chunks +24 lines, -8 lines 0 comments Download
M tools/relocation_packer/BUILD.gn View 5 chunks +22 lines, -10 lines 0 comments Download
M tools/relocation_packer/config.gni View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/xdisplaycheck/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M url/BUILD.gn View 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jamesr
6 years ago (2014-12-04 01:32:56 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
447ca5e902e7f80b24ba0d4826aaebf34a4f8203.

Powered by Google App Engine
This is Rietveld 408576698