Bugfix in ListProperty(), correctly handle list values of length 1

test/db/properties_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library gcloud.db.properties_test;
 
 import 'dart:typed_data';
 
 import 'package:gcloud/db.dart';
 import 'package:gcloud/datastore.dart' as datastore;
@@ skipping 93 matching lines @@
       expect(prop.decodePrimitiveValue(null, 99*1000), equals(utc99));
       expect(prop.decodePrimitiveValue(null, 99*1000 + 1), equals(utc99));
       expect(prop.decodePrimitiveValue(null, utc99), equals(utc99));
     });
 
     test('list_property', () {
       var prop = const ListProperty(const BoolProperty());
 
       expect(prop.validate(null, null), isFalse);
       expect(prop.validate(null, []), isTrue);
+      expect(prop.validate(null, [true]), isTrue);
       expect(prop.validate(null, [true, false]), isTrue);
       expect(prop.validate(null, [true, false, 1]), isFalse);
       expect(prop.encodeValue(null, []), equals(null));
       expect(prop.encodeValue(null, [true]), equals(true));
       expect(prop.encodeValue(null, [true, false]), equals([true, false]));
       expect(prop.decodePrimitiveValue(null, null), equals([]));
       expect(prop.decodePrimitiveValue(null, []), equals([]));
       expect(prop.decodePrimitiveValue(null, true), equals([true]));
       expect(prop.decodePrimitiveValue(null, [true, false]),
              equals([true, false]));
     });
 
+    test('composed_list_property', () {
+      var prop = const ListProperty(const CustomProperty());
+
+      var c1 = new Custom()..customValue = 'c1';
+      var c2 = new Custom()..customValue = 'c2';
+
+      expect(prop.validate(null, null), isFalse);
+      expect(prop.validate(null, []), isTrue);
+      expect(prop.validate(null, [c1]), isTrue);
+      expect(prop.validate(null, [c1, c2]), isTrue);
+      expect(prop.validate(null, [c1, c2, 1]), isFalse);
+      expect(prop.encodeValue(null, []), equals(null));
+      expect(prop.encodeValue(null, [c1]), equals(c1.customValue));
+      expect(prop.encodeValue(null, [c1, c2]),
+             equals([c1.customValue, c2.customValue]));
+      expect(prop.decodePrimitiveValue(null, null), equals([]));
+      expect(prop.decodePrimitiveValue(null, []), equals([]));
+      expect(prop.decodePrimitiveValue(null, c1.customValue), equals([c1]));
+      expect(prop.decodePrimitiveValue(null, [c1.customValue, c2.customValue]),
+             equals([c1, c2]));
+    });
+
     test('modelkey_property', () {
       var datastoreKey = new datastore.Key(
           [new datastore.KeyElement('MyKind', 42)],
           partition: new datastore.Partition('foonamespace'));
       var dbKey = new KeyMock(datastoreKey);
       var modelDBMock = new ModelDBMock(datastoreKey, dbKey);
 
       var prop = const ModelKeyProperty(required: true);
       expect(prop.validate(modelDBMock, null), isFalse);
 
       prop = const ModelKeyProperty(required: false);
       expect(prop.validate(modelDBMock, null), isTrue);
       expect(prop.validate(modelDBMock, dbKey), isTrue);
       expect(prop.validate(modelDBMock, datastoreKey), isFalse);
       expect(prop.encodeValue(modelDBMock, null), equals(null));
       expect(prop.encodeValue(modelDBMock, dbKey), equals(datastoreKey));
       expect(prop.decodePrimitiveValue(modelDBMock, null), equals(null));
       expect(prop.decodePrimitiveValue(modelDBMock, datastoreKey),
              equals(dbKey));
     });
   });
 }
 
+class Custom {
+  String customValue;
+
+  int get hashCode => customValue.hashCode;
+
+  bool operator==(other) {
+    return other is Custom && other.customValue == customValue;
+  }
+}
+
+class CustomProperty extends StringProperty {
+  const CustomProperty(
+      {String propertyName: null, bool required: false, bool indexed: true});
+
+  bool validate(ModelDB db, Object value) {
+    if (required && value == null) return false;
+    return value == null || value is Custom;
+  }
+
+  Object decodePrimitiveValue(ModelDB db, Object value) {
+    if (value == null) return null;
+    return new Custom()..customValue = value;
+  }
+
+  Object encodeValue(ModelDB db, Object value) {
+    if (value == null) return null;
+    return (value as Custom).customValue;
+  }
+}
+
 class KeyMock implements Key {
   datastore.Key _datastoreKey;
 
   KeyMock(this._datastoreKey);
 
   Object id = 1;
   Type type = null;
   Key get parent => this;
   bool get isEmpty => false;
   Partition get partition => null;
@@ skipping 20 matching lines @@
     }
     return _datastoreKey;
   }
 
   Map<String, Property> propertiesForModel(modelDescription) => null;
   Model fromDatastoreEntity(datastore.Entity entity) => null;
   datastore.Entity toDatastoreEntity(Model model) => null;
   String fieldNameToPropertyName(String kind, String fieldName) => null;
   String kindName(Type type) => null;
 }