Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 774193003: [turbofan] Use "leal" in even more situations (Closed)

Created:
6 years ago by danno
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@765983002
Project:
v8
Visibility:
Public.

Description

[turbofan] Use "leal" in even more situations Achieve more than parity with modes currently handled on ia32 in preparation for porting the entire mechanism to ia32, including supporting mul of constants 3, 5 and 9 with "leal" instructions. TEST=unittests

Patch Set 1 #

Patch Set 2 : Review candidate #

Patch Set 3 : Remove ia32 changes #

Patch Set 4 : Even faster #

Patch Set 5 : Better names #

Patch Set 6 : Latest #

Patch Set 7 : Fix stray character #

Patch Set 8 : Fix rename #

Patch Set 9 : Fix rename #

Patch Set 10 : Fix Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1070 lines, -715 lines) Patch
M src/compiler/node-matchers.h View 1 2 3 4 5 6 7 8 9 3 chunks +200 lines, -134 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 2 3 4 5 6 2 chunks +27 lines, -12 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 3 4 5 6 7 8 4 chunks +93 lines, -72 lines 0 comments Download
M test/unittests/compiler/node-matchers-unittest.cc View 1 2 3 4 5 6 6 chunks +606 lines, -497 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 1 chunk +144 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
danno
PTAL
6 years ago (2014-12-05 08:43:11 UTC) #2
Benedikt Meurer
This lea thing is really insane... LGTM
6 years ago (2014-12-05 08:47:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774193003/120001
6 years ago (2014-12-05 09:36:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/1663) v8_mac_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/1756)
6 years ago (2014-12-05 09:38:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774193003/160001
6 years ago (2014-12-05 09:43:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1566)
6 years ago (2014-12-05 09:46:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774193003/160001
6 years ago (2014-12-05 10:02:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/130)
6 years ago (2014-12-05 10:13:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774193003/180001
6 years ago (2014-12-05 10:33:57 UTC) #17
commit-bot: I haz the power
6 years ago (2014-12-05 10:54:33 UTC) #18
Message was sent while issue was closed.
Committed patchset #10 (id:180001)

Powered by Google App Engine
This is Rietveld 408576698