Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 774163005: Update test case TurboAsmDisablesNeuter for "Disable neutering on embedded arraybuffers" (Closed)

Created:
6 years ago by chunyang.dai
Modified:
6 years ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

update test case for "Disable neutering on embedded arraybuffers" This test case ( added by git: 4c7effe56e8dbe8e2df51bab967c8e1d251f3a66 ). should has different implementation for Turbofan and crankshaft. BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M test/cctest/test-api.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
chunyang.dai
hello, Dcarney. PTAL. thanks.
6 years ago (2014-12-08 10:12:15 UTC) #2
dcarney
lgtm with the requested change https://codereview.chromium.org/774163005/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/774163005/diff/1/test/cctest/test-api.cc#newcode24492 test/cctest/test-api.cc:24492: bool should_be_neuterable = !i::FLAG_turbo_asm; ...
6 years ago (2014-12-08 10:21:59 UTC) #3
chunyang.dai
Hi, Dcarney. I updated it as the following: #if V8_TURBOFAN_TARGET bool should_be_neuterable = !i::FLAG_turbo_asm; #else ...
6 years ago (2014-12-08 14:38:05 UTC) #4
dcarney
On 2014/12/08 14:38:05, chunyang.dai wrote: > Hi, Dcarney. > I updated it as the following: ...
6 years ago (2014-12-08 14:46:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774163005/20001
6 years ago (2014-12-08 14:46:42 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-08 15:14:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698