Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 774153007: Introduce new API language() to test lang attribute. (Closed)

Created:
6 years ago by k.czech
Modified:
6 years ago
Reviewers:
dmazzoni, dglazkov
CC:
dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Introduce new accessibility API, language(). Having this API we can test lang attribute that is reported properly. BUG=none TBR=dglazkov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186642

Patch Set 1 #

Patch Set 2 : Just adding new API. Removing tests. They will go later in the other patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M Source/web/WebAXObject.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M public/web/WebAXObject.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
k.czech
I'm not sure whether LayoutTests/accessibility/language-attribute-expected.txt were properly added.
6 years ago (2014-12-04 12:31:29 UTC) #1
dmazzoni
lgtm
6 years ago (2014-12-04 16:27:13 UTC) #3
dmazzoni
Note: the two changes depend on each other, you can'd land them this way without ...
6 years ago (2014-12-04 16:30:03 UTC) #4
k.czech
On 2014/12/04 16:30:03, dmazzoni wrote: > Note: the two changes depend on each other, you ...
6 years ago (2014-12-05 09:28:53 UTC) #5
k.czech
Applied Dominic's suggestions. I'm adding just API and removing tests.
6 years ago (2014-12-05 11:39:49 UTC) #6
dmazzoni
lgtm
6 years ago (2014-12-06 07:57:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774153007/20001
6 years ago (2014-12-06 07:57:24 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-06 09:06:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186642

Powered by Google App Engine
This is Rietveld 408576698