Issue 774143006: Replace strings with ints to avoid comdat folding on the thread watcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 774143006: Replace strings with ints to avoid comdat folding on the thread watcher. (Closed)

Created:
6 years ago by rvargas (doing something else)

Modified:
6 years ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Replace strings with ints to avoid comdat folding on the thread watcher. __LINE__ is slightly more efficient than __FUNCTION__ BUG=436123 R=rtenneti@chromium.org Committed: https://crrev.com/1605706caffacf532e2527f3f45a9c3d8e5b8ff5 Cr-Commit-Position: refs/heads/master@{#306703}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	chrome/browser/metrics/thread_watcher_report_hang.cc	View		1 chunk	+9 lines, -9 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774143006/1

6 years ago (2014-12-03 22:31:33 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-03 23:08:09 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1605706caffacf532e2527f3f45a9c3d8e5b8ff5
Cr-Commit-Position: refs/heads/master@{#306703}