Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 7741015: Fix minor compilation issue on X64. (Closed)

Created:
9 years, 4 months ago by Michael Starzinger
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix minor compilation issue on X64. R=lrn@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=9012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/heap.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
9 years, 4 months ago (2011-08-25 09:52:28 UTC) #1
Erik Corry
Would it work just as well to make kPageSize into an intptr_t or does that ...
9 years, 4 months ago (2011-08-25 10:07:50 UTC) #2
Erik Corry
On 2011/08/25 10:07:50, Erik Corry wrote: > Would it work just as well to make ...
9 years, 4 months ago (2011-08-25 10:08:21 UTC) #3
Lasse Reichstein
What Erik says. LGTM too.
9 years, 4 months ago (2011-08-25 10:11:17 UTC) #4
Michael Starzinger
9 years, 4 months ago (2011-08-25 10:47:57 UTC) #5
On 2011/08/25 10:07:50, Erik Corry wrote:
> Would it work just as well to make kPageSize into an intptr_t or does that
cause
> a cascade of other changes?

Yep, changing kPageSize would cause many other changes.

Powered by Google App Engine
This is Rietveld 408576698