Issue 774073002: Revert of rebaseline after clear change -- pdf was not treating clear as SRC_MODE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 774073002: Revert of rebaseline after clear change -- pdf was not treating clear as SRC_MODE (Closed)

Created:
6 years ago by reed2

Modified:
6 years ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of rebaseline after clear change -- pdf was not treating clear as SRC_MODE (patchset #1 id:1 of https://codereview.chromium.org/759303004/) Reason for revert: reverted clear() change Original issue's description: > rebaseline after clear change -- pdf was not treating clear as SRC_MODE > > BUG=skia: > NOTRY=True > TBR= > > Committed: https://skia.googlesource.com/skia/+/2fb352abebc342a322d4a66c054bbff8bd565767 TBR=reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2b06ddc1791e9f3e004831b06a39b5b85ac9d5f0

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -54 lines)			Patch
M	expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json	View	6 chunks	+12 lines, -9 lines	0 comments	Download
M	expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json	View	6 chunks	+12 lines, -9 lines	0 comments	Download
M	expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json	View	6 chunks	+12 lines, -9 lines	0 comments	Download
M	expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json	View	6 chunks	+12 lines, -9 lines	0 comments	Download
M	expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json	View	11 chunks	+21 lines, -18 lines	0 comments	Download

Total messages: 3 (0 generated)

reed2

Created Revert of rebaseline after clear change -- pdf was not treating clear as SRC_MODE

6 years ago (2014-12-03 04:04:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/774073002/1

6 years ago (2014-12-03 04:04:31 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-03 04:04:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2b06ddc1791e9f3e004831b06a39b5b85ac9d5f0