Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4847)

Unified Diff: chrome/renderer/autofill/form_autocomplete_browsertest.cc

Issue 7740070: Add metrics to measure time elapsed between form load and form submission with or without Autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Serialize in all the right places Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/form_autocomplete_browsertest.cc
diff --git a/chrome/renderer/autofill/form_autocomplete_browsertest.cc b/chrome/renderer/autofill/form_autocomplete_browsertest.cc
index 9d58e943ff2f8bf85263d4016d85ef39c3832d32..101b8120c418b8205449dd3996a3c16455b31eca 100644
--- a/chrome/renderer/autofill/form_autocomplete_browsertest.cc
+++ b/chrome/renderer/autofill/form_autocomplete_browsertest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "base/time.h"
#include "chrome/common/autofill_messages.h"
#include "chrome/test/base/render_view_test.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -35,7 +36,8 @@ TEST_F(FormAutocompleteTest, NormalFormSubmit) {
AutofillHostMsg_FormSubmitted::ID);
ASSERT_TRUE(message != NULL);
- Tuple1<FormData> forms;
+ // The tuple also includes a timestamp, which is ignored.
+ Tuple2<FormData, base::TimeTicks> forms;
AutofillHostMsg_FormSubmitted::Read(message, &forms);
ASSERT_EQ(2U, forms.a.fields.size());
@@ -83,7 +85,8 @@ TEST_F(FormAutocompleteTest, AutoCompleteOffInputSubmit) {
AutofillHostMsg_FormSubmitted::ID);
ASSERT_TRUE(message != NULL);
- Tuple1<FormData> forms;
+ // The tuple also includes a timestamp, which is ignored.
+ Tuple2<FormData, base::TimeTicks> forms;
AutofillHostMsg_FormSubmitted::Read(message, &forms);
ASSERT_EQ(1U, forms.a.fields.size());

Powered by Google App Engine
This is Rietveld 408576698