Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2151)

Unified Diff: chrome/browser/autofill/form_structure.h

Issue 7740070: Add metrics to measure time elapsed between form load and form submission with or without Autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Once more, with feeling Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/autofill_type.cc ('k') | chrome/browser/autofill/form_structure.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/form_structure.h
diff --git a/chrome/browser/autofill/form_structure.h b/chrome/browser/autofill/form_structure.h
index 4f154d450332b72992c9ffc1212270a61dd3c93a..9824c36294e9594013a75b3c135df2e0c6bbbfc3 100644
--- a/chrome/browser/autofill/form_structure.h
+++ b/chrome/browser/autofill/form_structure.h
@@ -30,6 +30,10 @@ enum UploadRequired {
class AutofillMetrics;
+namespace base {
+class TimeTicks;
+}
+
namespace buzz {
class XmlElement;
}
@@ -106,8 +110,13 @@ class FormStructure {
// Logs quality metrics for |this|, which should be a user-submitted form.
// This method should only be called after the possible field types have been
- // set for each field.
- void LogQualityMetrics(const AutofillMetrics& metric_logger) const;
+ // set for each field. |interaction_time| should be a timestamp corresponding
+ // to the user's first interaction with the form. |submission_time| should be
+ // a timestamp corresponding to the form's submission.
+ void LogQualityMetrics(const AutofillMetrics& metric_logger,
+ const base::TimeTicks& load_time,
+ const base::TimeTicks& interaction_time,
+ const base::TimeTicks& submission_time) const;
const AutofillField* field(size_t index) const;
AutofillField* field(size_t index);
« no previous file with comments | « chrome/browser/autofill/autofill_type.cc ('k') | chrome/browser/autofill/form_structure.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698