Add metrics to measure time elapsed between form load and form submission with or without Autofill.

chrome/browser/autofill/form_structure.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/form_structure.h"
 
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/sha1.h"
 #include "base/stringprintf.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
+#include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/autofill/autofill_metrics.h"
 #include "chrome/browser/autofill/autofill_type.h"
 #include "chrome/browser/autofill/autofill_xml_parser.h"
 #include "chrome/browser/autofill/field_types.h"
 #include "chrome/browser/autofill/form_field.h"
 #include "third_party/libjingle/source/talk/xmllite/xmlelement.h"
 #include "webkit/glue/form_data.h"
 #include "webkit/glue/form_data_predictions.h"
 #include "webkit/glue/form_field.h"
@@ skipping 614 matching lines @@
   // rearranged via JavaScript between page load and form submission, so we
   // copy over the |form_signature_field_names_| corresponding to the query
   // request.
   DCHECK_EQ(cached_form.form_name_, form_name_);
   DCHECK_EQ(cached_form.source_url_, source_url_);
   DCHECK_EQ(cached_form.target_url_, target_url_);
   form_signature_field_names_ = cached_form.form_signature_field_names_;
 }
 
 void FormStructure::LogQualityMetrics(
-    const AutofillMetrics& metric_logger) const {
+    const AutofillMetrics& metric_logger,
+    const base::TimeTicks& interaction_time,
+    const base::TimeTicks& submission_time) const {
   std::string experiment_id = server_experiment_id();
   metric_logger.LogServerExperimentIdForUpload(experiment_id);
 
   size_t num_detected_field_types = 0;
   bool did_autofill_all_possible_fields = true;
   bool did_autofill_some_possible_fields = false;
   for (size_t i = 0; i < field_count(); ++i) {
     const AutofillField* field = this->field(i);
     metric_logger.LogQualityMetric(AutofillMetrics::FIELD_SUBMITTED,
                                    experiment_id);
@@ skipping 111 matching lines @@
         metric_logger.LogQualityMetric(
             AutofillMetrics::NOT_AUTOFILLED_SERVER_TYPE_MISMATCH,
             experiment_id);
       }
     }
   }
 
   if (num_detected_field_types < kRequiredFillableFields) {
     metric_logger.LogUserHappinessMetric(
         AutofillMetrics::SUBMITTED_NON_FILLABLE_FORM);
-  } else if (did_autofill_all_possible_fields) {
-    metric_logger.LogUserHappinessMetric(
-        AutofillMetrics::SUBMITTED_FILLABLE_FORM_AUTOFILLED_ALL);
-  } else if (did_autofill_some_possible_fields) {
-    metric_logger.LogUserHappinessMetric(
-        AutofillMetrics::SUBMITTED_FILLABLE_FORM_AUTOFILLED_SOME);
   } else {
-    metric_logger.LogUserHappinessMetric(
-        AutofillMetrics::SUBMITTED_FILLABLE_FORM_AUTOFILLED_NONE);
+    if (did_autofill_all_possible_fields) {
+      metric_logger.LogUserHappinessMetric(
+          AutofillMetrics::SUBMITTED_FILLABLE_FORM_AUTOFILLED_ALL);
+    } else if (did_autofill_some_possible_fields) {
+      metric_logger.LogUserHappinessMetric(
+          AutofillMetrics::SUBMITTED_FILLABLE_FORM_AUTOFILLED_SOME);
+    } else {
+      metric_logger.LogUserHappinessMetric(
+          AutofillMetrics::SUBMITTED_FILLABLE_FORM_AUTOFILLED_NONE);
+    }
+
+    // Only log timing metrics if both timestamps are set and seem plausible.
+    if (!interaction_time.is_null() && !submission_time.is_null() &&

[dhollowa, 2011/08/31 22:40:52]

Could you explain why this is needed.  It seems like this could mask bugs.

[Ilya Sherman, 2011/08/31 23:21:32]

Done.

[dhollowa, 2011/08/31 23:42:20]

Sorry, my thinking was to let the bad data propagate through to the metrics so
we could actually detect bugs in the data.

+        submission_time > interaction_time) {
+      base::TimeDelta time_delta = submission_time - interaction_time;
+      if (did_autofill_some_possible_fields)
+        metric_logger.LogAutofilledFormSubmittedAfterDuration(time_delta);
+      else
+        metric_logger.LogNonAutofilledFormSubmittedAfterDuration(time_delta);
+    }
   }
 }
 
 const AutofillField* FormStructure::field(size_t index) const {
   if (index >= fields_.size()) {
     NOTREACHED();
     return NULL;
   }
 
   return fields_[index];
@@ skipping 160 matching lines @@
     if (current_type != UNKNOWN_TYPE && already_saw_current_type) {
       // We reached the end of a section, so start a new section.
       seen_types.clear();
       current_section = (*field)->unique_name();
     }
 
     seen_types.insert(current_type);
     (*field)->set_section(current_section);
   }
 }