chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc - Issue 774003002: [Hotword] Reverse the experimental flag so that it is on by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc

Issue 774003002: [Hotword] Reverse the experimental flag so that it is on by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix browser test Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc

diff --git a/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc b/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc

index 0bbc01bd809669e5fa8acc06c10a35d4707b3156..39ae48143fe06d759100f993ec3954296b255bd8 100644

--- a/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc

+++ b/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc

@@ -270,8 +270,8 @@ IN_PROC_BROWSER_TEST_F(HotwordPrivateApiTest, AlwaysOnEnabled) {

}

IN_PROC_BROWSER_TEST_F(HotwordPrivateApiTest, ExperimentalHotwordEnabled) {

- // Disabled by default.

- ExtensionTestMessageListener listener("experimentalHotwordEnabled: false",

+ // Enabled by default.

+ ExtensionTestMessageListener listener("experimentalHotwordEnabled: true",

false);

ASSERT_TRUE(RunComponentExtensionTest("experimentalHotwordEnabled"))

<< message_;

@@ -280,8 +280,6 @@ IN_PROC_BROWSER_TEST_F(HotwordPrivateApiTest, ExperimentalHotwordEnabled) {

IN_PROC_BROWSER_TEST_F(HotwordPrivateApiTest,

ExperimentalHotwordEnabled_Enabled) {

- base::CommandLine::ForCurrentProcess()->AppendSwitch(

- switches::kEnableExperimentalHotwording);

ExtensionTestMessageListener listener("experimentalHotwordEnabled: true",

false);

ASSERT_TRUE(RunComponentExtensionTest("experimentalHotwordEnabled"))

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/extensions/hotword_browsertest.cc » ('j') | no next file with comments »