[Hotword] Reverse the experimental flag so that it is on by default.

[Hotword] Reverse the experimental flag so that it is on by default.

This means that v2 hotword (using the shared module instead of the CWS
extension) will be the default.

Updates tests to account for new default.

The next CL will take care of cleaning up usage of IsExperimentalHotwordingEnabled().

BUG=432995
Committed: https://crrev.com/2cd75c128306f0975c904574750c12c6cf8ea367
Cr-Commit-Position: refs/heads/master@{#306730}

[rpetterson, 2014-12-03 00:50:26]

rlp@chromium.org changed reviewers:
+ amistry@chromium.org, benwells@chromium.org

[rpetterson, 2014-12-03 00:50:26]

amistry - overall

benwells -- OWNERS for speech_recognizer_browsertest and hotword_private_apitest

[benwells, 2014-12-03 03:55:17]

The two files I was asked to look at lgtm

[Anand Mistry (off Chromium), 2014-12-03 04:04:53]

LGTM with one change.

Yay! This calls for cake.

https://codereview.chromium.org/774003002/diff/20001/chrome/common/chrome_swi...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/774003002/diff/20001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:454: // Enables v2 hotword detection features.
These features include
s/Enables/Disables

[rpetterson, 2014-12-03 06:54:39]

I agree that cake is in order :) This is the best I can do until you all come
back to MTV ;)

     |------|
     |           |
  |---------|
  |                 |
|------------|
|                      |
|______________|

https://codereview.chromium.org/774003002/diff/20001/chrome/common/chrome_swi...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/774003002/diff/20001/chrome/common/chrome_swi...
chrome/common/chrome_switches.cc:454: // Enables v2 hotword detection features.
These features include
On 2014/12/03 04:04:53, Anand Mistry wrote:
> s/Enables/Disables

Done.

[rpetterson, 2014-12-03 06:55:30]

On 2014/12/03 06:54:39, rpetterson wrote:
> I agree that cake is in order :) This is the best I can do until you all come
> back to MTV ;)
> 
>      |------|
>      |           |
>   |---------|
>   |                 |
> |------------|
> |                      |
> |______________|
> 
>
https://codereview.chromium.org/774003002/diff/20001/chrome/common/chrome_swi...
> File chrome/common/chrome_switches.cc (right):
> 
>
https://codereview.chromium.org/774003002/diff/20001/chrome/common/chrome_swi...
> chrome/common/chrome_switches.cc:454: // Enables v2 hotword detection
features.
> These features include
> On 2014/12/03 04:04:53, Anand Mistry wrote:
> > s/Enables/Disables
> 
> Done.

And apparently codereview did not like my cake :-/

[rpetterson, 2014-12-03 08:23:58]

rlp@chromium.org changed reviewers:
+ mpearson@chromium.org

[rpetterson, 2014-12-03 08:23:59]

mpearson@ -- please take a look at histograms.xml.

Note: I did not remove the old flag since my understanding is that it's bad to
remove histogram values (since they may come in from old versions). Please let
me know if I should remove the old value in this case.

[rpetterson, 2014-12-03 19:08:54]

Anand, PTAL. I had to update the HotwordBrowserTest as well. Once we go to
stable, we can remove this test since it only tests v1, right? Or do we need
something similar for v2?

[Mark P, 2014-12-03 19:09:50]

histograms.xml lgtm

On 2014/12/03 08:23:59, rpetterson wrote:
> mpearson@ -- please take a look at histograms.xml.
> 
> Note: I did not remove the old flag since my understanding is that it's bad to
> remove histogram values (since they may come in from old versions). Please let
> me know if I should remove the old value in this case.

Keeping the old flag histogram value sgtm.

[Anand Mistry (off Chromium), 2014-12-03 23:13:39]

LGTM

On 2014/12/03 19:08:54, rpetterson wrote:
> Anand, PTAL. I had to update the HotwordBrowserTest as well. Once we go to
> stable, we can remove this test since it only tests v1, right? Or do we need
> something similar for v2?

The bug it tests is only in v1 (in the hotword_helper extension). It can be
deleted along with all the other v1 stuff when we do so.

[rpetterson, 2014-12-03 23:14:12]

The CQ bit was checked by rlp@chromium.org

[commit-bot: I haz the power, 2014-12-03 23:15:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/774003002/80001

[commit-bot: I haz the power, 2014-12-04 00:26:52]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-12-04 00:27:56]

Patchset 5 (id:??) landed as
https://crrev.com/2cd75c128306f0975c904574750c12c6cf8ea367
Cr-Commit-Position: refs/heads/master@{#306730}

[Anand Mistry (off Chromium), 2014-12-04 05:14:19]

On 2014/12/03 06:55:30, rpetterson wrote:
> On 2014/12/03 06:54:39, rpetterson wrote:
> > I agree that cake is in order :) This is the best I can do until you all
come
> > back to MTV ;)
> > 
> >      |------|
> >      |           |
> >   |---------|
> >   |                 |
> > |------------|
> > |                      |
> > |______________|
> > 
> >
>
https://codereview.chromium.org/774003002/diff/20001/chrome/common/chrome_swi...
> > File chrome/common/chrome_switches.cc (right):
> > 
> >
>
https://codereview.chromium.org/774003002/diff/20001/chrome/common/chrome_swi...
> > chrome/common/chrome_switches.cc:454: // Enables v2 hotword detection
> features.
> > These features include
> > On 2014/12/03 04:04:53, Anand Mistry wrote:
> > > s/Enables/Disables
> > 
> > Done.
> 
> And apparently codereview did not like my cake :-/

Maybe it likes this one:
https://drive.google.com/a/google.com/file/d/0BxPuWSeoHD_uTlhaWjNSOGJPQVFnLXN...