Optimize add/set/delete operations for string keys in Maps and Sets

Optimize add/set/delete operations for string keys in Maps and Sets

[adamk, 2014-12-03 03:27:20]

adamk@chromium.org changed reviewers:
+ dslomov@chromium.org

[adamk, 2014-12-03 03:35:51]

I think this is ready for review. Some of these names are getting really long,
let me know if you'd like me to split this off into its own class so every
method doesn't have to begin with "BuildOrderedHashTable..."

[adamk, 2014-12-03 03:44:14]

On 2014/12/03 03:35:51, adamk wrote:
> I think this is ready for review. Some of these names are getting really long,
> let me know if you'd like me to split this off into its own class so every
> method doesn't have to begin with "BuildOrderedHashTable..."

Sorry, you can hold off on review for now, I realized I wanted to handle
shrinking for the delete case but I don't have that code written yet.

[adamk, 2014-12-03 04:03:33]

On 2014/12/03 03:44:14, adamk wrote:
> On 2014/12/03 03:35:51, adamk wrote:
> > I think this is ready for review. Some of these names are getting really
long,
> > let me know if you'd like me to split this off into its own class so every
> > method doesn't have to begin with "BuildOrderedHashTable..."
> 
> Sorry, you can hold off on review for now, I realized I wanted to handle
> shrinking for the delete case but I don't have that code written yet.

That was easier than I thought, I've added shrinking logic (bailing out to the
runtime if we'll need to shrink). PTAL.

[Dmitry Lomov (no reviews), 2014-12-04 13:19:07]

lgtm! very cool

[arv (Not doing code reviews), 2014-12-04 13:47:29]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2014-12-04 13:47:30]

At this point I'm starting to wonder if we should revive the JS implementation I
had?

[adamk, 2014-12-04 18:16:30]

On 2014/12/04 13:47:30, arv wrote:
> At this point I'm starting to wonder if we should revive the JS implementation
I
> had?

Yeah, I think there's definitely some of this logic that could be pushed up into
script.

[adamk, 2014-12-04 19:40:47]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2014-12-04 19:41:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/773993002/70001

[commit-bot: I haz the power, 2014-12-04 20:07:51]

Committed patchset #5 (id:70001)

[adamk, 2014-12-04 21:36:17]

A revert of this CL (patchset #5 id:70001) has been created in
https://codereview.chromium.org/777233003/ by adamk@chromium.org.

The reason for reverting is: Caused test failures in mjsunit/es6/collections
with --deopt-every-n-times=1.