Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 773943002: Add MachMessageWithDeadline() and supporting characters (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@mach_message_util_move
Project:
crashpad
Visibility:
Public.

Description

Add MachMessageWithDeadline() and supporting characters. MachMessageWithDeadline() is a mach_msg() wrapper that deals with deadlines instead of timeouts. It is a slight simplification of the mach_msg() interface because the deadline parameter implies the timeout option bits, and because the caller does not need to specify send_size during sends as the message itself already carries this information. TEST=util_test MachMessage.MachMessageDeadlineFromTimeout R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/dce497446e6fb29124bf3668d89a4302d667531d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -0 lines) Patch
M util/mach/mach_message.h View 1 chunk +74 lines, -0 lines 0 comments Download
M util/mach/mach_message.cc View 1 chunk +169 lines, -0 lines 0 comments Download
M util/mach/mach_message_test.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
This is the second in a series of changes that improves the design of MachMessageServer. ...
6 years ago (2014-12-02 21:52:12 UTC) #2
Robert Sesek
LGTM
6 years ago (2014-12-02 22:06:55 UTC) #3
Mark Mentovai
6 years ago (2014-12-02 22:09:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dce497446e6fb29124bf3668d89a4302d667531d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698