Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 773933002: GAS: Handle multiple fixups in bundle for call adjustment (Closed)

Created:
6 years ago by Roland McGrath
Modified:
6 years ago
Reviewers:
sehr, Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/nacl-binutils.git@nacl-hacks
Visibility:
Public.

Description

GAS: Handle multiple fixups in bundle for call adjustment When using .bundle_lock, there can be multiple instructions, and thus multiple fixups (relocs to generate) in a single frag. When the frag ends in a call instruction, all those fixups need to be adjusted for the rearrangement of the instruction bytes done to move the call instruction to the end of the bundle. This also drops the ancient, unused, and unsupported handling of the NACL_CONTROL_ENFORCE_RANGE environment variable. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4008 TEST= manual inspection of test case R=dschuff@chromium.org, sehr@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-binutils.git;a=commit;h=1d8592cc9f02cc9aeaef992c296376a8fd4c8761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M gas/frags.h View 1 chunk +6 lines, -2 lines 0 comments Download
M gas/write.c View 3 chunks +17 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Roland McGrath
6 years ago (2014-12-02 21:36:04 UTC) #1
sehr
LGTM and thanks for expunging more prototype code (seven years later :-) ).
6 years ago (2014-12-02 21:42:02 UTC) #2
Derek Schuff
On 2014/12/02 21:42:02, sehr (please use this account) wrote: > LGTM and thanks for expunging ...
6 years ago (2014-12-02 22:19:52 UTC) #3
Derek Schuff
On 2014/12/02 22:19:52, Derek Schuff wrote: > On 2014/12/02 21:42:02, sehr (please use this account) ...
6 years ago (2014-12-02 22:20:17 UTC) #4
Roland McGrath
6 years ago (2014-12-02 22:50:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d8592cc9f02cc9aeaef992c296376a8fd4c8761 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698