Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: src/arm/lithium-arm.cc

Issue 7739018: Inline functions with different contexts in the optimizing code generator. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase to current tip-of-tree. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/arm/lithium-arm.cc
diff --git a/src/arm/lithium-arm.cc b/src/arm/lithium-arm.cc
index 30ccd05beecb39c979a4dbe91ee301d381390d7d..6f7f54485891bd874209c7453a6cb4c8c55f958f 100644
--- a/src/arm/lithium-arm.cc
+++ b/src/arm/lithium-arm.cc
@@ -1109,6 +1109,15 @@ LInstruction* LChunkBuilder::DoContext(HContext* instr) {
}
+LInstruction* LChunkBuilder::DoInlinedContext(HInlinedContext* instr) {
+ // All implicit uses of the context from the context register or from
+ // the stack frame must be replaced with uses of HContext values
+ // before HInlinedContext will work.
+ UNREACHABLE();
+ return instr->HasNoUses() ? NULL : DefineAsRegister(new LInlinedContext);
Kevin Millikin (Chromium) 2011/09/15 11:17:24 Just UNREACHABLE, please, no untested dead code.
+}
+
+
LInstruction* LChunkBuilder::DoOuterContext(HOuterContext* instr) {
LOperand* context = UseRegisterAtStart(instr->value());
return DefineAsRegister(new LOuterContext(context));
@@ -2166,7 +2175,8 @@ LInstruction* LChunkBuilder::DoEnterInlined(HEnterInlined* instr) {
HEnvironment* inner = outer->CopyForInlining(instr->closure(),
instr->function(),
undefined,
- instr->call_kind());
+ instr->call_kind(),
+ instr->context_changed());
current_block_->UpdateEnvironment(inner);
chunk_->AddInlinedClosure(instr->closure());
return NULL;

Powered by Google App Engine
This is Rietveld 408576698