Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 773883003: [DevTools] Console view should hide the suggestion box upon console clear (Ctrl/Cmd+L). (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
Reviewers:
vivekg, pfeldman
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[DevTools] Console view should hide the suggestion box upon console clear (Ctrl/Cmd+L). This CL hides the suggestion box shown on the console prompt. When the developer has typed a character on the prompt (the prompt is somewhere down the viewport) and he presses Ctrl/Cmd+L to clear the console, the suggestion box stays in skewed manner. R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186391

Patch Set 1 #

Patch Set 2 : Reuploading the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/devtools/front_end/console/ConsoleView.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
vivekg
Hello Pavel, please take a look. Here is the screenshot of the issue http://pasteboard.co/29xkHnRI.png
6 years ago (2014-12-03 05:42:35 UTC) #2
pfeldman
Your patch did not upload!
6 years ago (2014-12-03 05:57:13 UTC) #3
vivekg
On 2014/12/03 at 05:57:13, pfeldman wrote: > Your patch did not upload! The side-by-side view ...
6 years ago (2014-12-03 06:06:35 UTC) #4
pfeldman
We typically re-upload in case this thing happens.
6 years ago (2014-12-03 06:10:35 UTC) #5
vivekg
On 2014/12/03 at 06:10:35, pfeldman wrote: > We typically re-upload in case this thing happens. ...
6 years ago (2014-12-03 06:13:38 UTC) #6
pfeldman
lgtm
6 years ago (2014-12-03 06:14:00 UTC) #7
vivekg
On 2014/12/03 at 06:14:00, pfeldman wrote: > lgtm Thank you. :)
6 years ago (2014-12-03 06:15:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773883003/20001
6 years ago (2014-12-03 06:16:42 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-03 08:34:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186391

Powered by Google App Engine
This is Rietveld 408576698