components/password_manager/core/browser/password_form_manager.h - Issue 773823002: PasswordManager should trigger autofill for new forms + old PasswordFromManagers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 773823002: PasswordManager should trigger autofill for new forms + old PasswordFromManagers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't duplicate the blacklist & generation IPC Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.h

diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h

index b3a5c0f2730cadbab22790ce80fedbdb9ebd7665..6228833c3f59f0a34393e533f19c7ecf7f3c520e 100644

--- a/components/password_manager/core/browser/password_form_manager.h

+++ b/components/password_manager/core/browser/password_form_manager.h

@@ -109,6 +109,10 @@ class PasswordFormManager : public PasswordStoreConsumer {

// Takes ownership of the elements in |result|.

void OnRequestDone(const std::vector<autofill::PasswordForm*>& result);

+ // If reasonable, non-blacklisted, candidates were found by the password

+ // store, this will trigger the autofill through PasswordManager.

+ void MaybeTriggerAutofill();

void OnGetPasswordStoreResults(

const std::vector<autofill::PasswordForm*>& results) override;