chrome/test/data/password/dynamic_password_form.html - Issue 773823002: PasswordManager should trigger autofill for new forms + old PasswordFromManagers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/password/dynamic_password_form.html

Issue 773823002: PasswordManager should trigger autofill for new forms + old PasswordFromManagers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't duplicate the blacklist & generation IPC Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/password/dynamic_password_form.html

diff --git a/chrome/test/data/password/dynamic_password_form.html b/chrome/test/data/password/dynamic_password_form.html

index 2e97fda1e2e6e718f80f3564a2a4bf7c72ab0f0b..ed22c72dadd3eba458f7d66cd3ae716cc9646315 100644

--- a/chrome/test/data/password/dynamic_password_form.html

+++ b/chrome/test/data/password/dynamic_password_form.html

@@ -4,6 +4,7 @@

function createDynamicForm() {

var dynamicForm = document.createElement('form');

dynamicForm.setAttribute('name', 'dynamic_form');

+ dynamicForm.setAttribute('id', 'dynamic_form_id');

dynamicForm.setAttribute('method', 'post');

dynamicForm.setAttribute('action', 'done.html');

dynamicForm.setAttribute('onsubmit', 'return true;');

@@ -11,6 +12,7 @@ function createDynamicForm() {

var inputUsername = document.createElement('input');

inputUsername.setAttribute('type', 'text');

inputUsername.setAttribute('name', 'username');

+ inputUsername.setAttribute('id', 'username_id');

var inputPassword = document.createElement('input');

inputPassword.setAttribute('type', 'password');