PasswordManager should trigger autofill for new forms + old PasswordFromManagers

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
@@ skipping 977 matching lines @@
     bool form_contains_username_field = FillDataContainsUsername(form_data);
     if (form_contains_username_field) {
       username_element =
           form_elements->input_elements[form_data.username_field.name];
     }
 
     // No password field, bail out.
     if (form_data.password_field.name.empty())
       break;
 
+    // We might have already filled this form if there are two <form> elements
+    // with identical markup.
+    if (login_to_password_info_.find(username_element) !=
+        login_to_password_info_.end())
+      continue;
+
     // Get pointer to password element. (We currently only support single
     // password forms).
     password_element =
         form_elements->input_elements[form_data.password_field.name];
 
     // If wait_for_username is true, we don't want to initially fill the form
     // until the user types in a valid username.
     if (!form_data.wait_for_username &&
         FillFormOnPasswordRecieved(
             form_data,
             username_element,
             password_element,
             base::Bind(&PasswordValueGatekeeper::RegisterElement,
                        base::Unretained(&gatekeeper_)))) {
       usernames_usage_ = OTHER_POSSIBLE_USERNAME_SELECTED;
     }
-    // We might have already filled this form if there are two <form> elements
-    // with identical markup.
-    if (login_to_password_info_.find(username_element) !=
-        login_to_password_info_.end())
-      continue;
 
     PasswordInfo password_info;
     password_info.fill_data = form_data;
     password_info.password_field = password_element;
     login_to_password_info_[username_element] = password_info;
     password_to_username_[password_element] = username_element;
     login_to_password_info_key_[username_element] = key;
   }
 }
 
@@ skipping 182 matching lines @@
   agent_->WillSendSubmitEvent(frame, form);
 }
 
 void PasswordAutofillAgent::LegacyPasswordAutofillAgent::WillSubmitForm(
     blink::WebLocalFrame* frame,
     const blink::WebFormElement& form) {
   agent_->WillSubmitForm(frame, form);
 }
 
 }  // namespace autofill