Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 773793002: Make battery level an option for android provision devices. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
Reviewers:
navabi1, jbudorick, ulan
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make battery level an option for android provision devices. This will allow to specify less than 95% for perf bots that don't switch of usb charging. BUG=393538 Committed: https://crrev.com/fbc778129029b8711e080dbe0df9b92276ff0485 Cr-Commit-Position: refs/heads/master@{#306580}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/android/provision_devices.py View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Achenbach
PTAL
6 years ago (2014-12-02 13:40:05 UTC) #2
ulan
lgtm
6 years ago (2014-12-02 13:40:45 UTC) #3
jbudorick
lgtm w/ nit https://codereview.chromium.org/773793002/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/773793002/diff/1/build/android/provision_devices.py#newcode241 build/android/provision_devices.py:241: help="Minimum battery level for performance testing.") ...
6 years ago (2014-12-02 15:12:28 UTC) #4
Michael Achenbach
https://codereview.chromium.org/773793002/diff/1/build/android/provision_devices.py File build/android/provision_devices.py (right): https://codereview.chromium.org/773793002/diff/1/build/android/provision_devices.py#newcode241 build/android/provision_devices.py:241: help="Minimum battery level for performance testing.") On 2014/12/02 15:12:28, ...
6 years ago (2014-12-03 09:23:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773793002/20001
6 years ago (2014-12-03 09:23:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 10:23:40 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-03 10:24:20 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fbc778129029b8711e080dbe0df9b92276ff0485
Cr-Commit-Position: refs/heads/master@{#306580}

Powered by Google App Engine
This is Rietveld 408576698