Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3583)

Unified Diff: chromeos/network/network_state_handler.cc

Issue 773703002: Generalize network_event_log -> device_event_log (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + feedback Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/network_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_state_handler.cc
diff --git a/chromeos/network/network_state_handler.cc b/chromeos/network/network_state_handler.cc
index bbfa6ce7df971f6a33925e6a11ee7f54317475bb..a4562b054d16c48b9646d125983a648ca0a2e70a 100644
--- a/chromeos/network/network_state_handler.cc
+++ b/chromeos/network/network_state_handler.cc
@@ -7,6 +7,8 @@
#include "base/bind.h"
#include "base/format_macros.h"
#include "base/guid.h"
+#include "base/json/json_string_value_serializer.h"
+#include "base/json/json_writer.h"
#include "base/location.h"
#include "base/logging.h"
#include "base/metrics/histogram.h"
@@ -51,6 +53,13 @@ std::string GetLogName(const ManagedState* state) {
state->path().c_str());
}
+std::string ValueAsString(const base::Value& value) {
+ std::string vstr;
+ base::JSONWriter::WriteWithOptions(
+ &value, base::JSONWriter::OPTIONS_OMIT_BINARY_VALUES, &vstr);
+ return vstr.empty() ? "''" : vstr;
+}
+
} // namespace
const char NetworkStateHandler::kDefaultCheckPortalList[] =
@@ -82,20 +91,20 @@ void NetworkStateHandler::AddObserver(
NetworkStateHandlerObserver* observer,
const tracked_objects::Location& from_here) {
observers_.AddObserver(observer);
- network_event_log::internal::AddEntry(
- from_here.file_name(), from_here.line_number(),
- network_event_log::LOG_LEVEL_DEBUG,
- "NetworkStateHandler::AddObserver", "");
+ device_event_log::AddEntry(from_here.file_name(), from_here.line_number(),
+ device_event_log::LOG_TYPE_NETWORK,
+ device_event_log::LOG_LEVEL_DEBUG,
+ "NetworkStateHandler::AddObserver");
}
void NetworkStateHandler::RemoveObserver(
NetworkStateHandlerObserver* observer,
const tracked_objects::Location& from_here) {
observers_.RemoveObserver(observer);
- network_event_log::internal::AddEntry(
- from_here.file_name(), from_here.line_number(),
- network_event_log::LOG_LEVEL_DEBUG,
- "NetworkStateHandler::RemoveObserver", "");
+ device_event_log::AddEntry(from_here.file_name(), from_here.line_number(),
+ device_event_log::LOG_TYPE_NETWORK,
+ device_event_log::LOG_LEVEL_DEBUG,
+ "NetworkStateHandler::RemoveObserver");
}
NetworkStateHandler::TechnologyState NetworkStateHandler::GetTechnologyState(
@@ -569,12 +578,12 @@ void NetworkStateHandler::UpdateNetworkServiceProperty(
}
// Log event.
std::string detail = network->name() + "." + key;
- detail += " = " + network_event_log::ValueAsString(value);
- network_event_log::LogLevel log_level;
+ detail += " = " + ValueAsString(value);
+ device_event_log::LogLevel log_level;
if (key == shill::kErrorProperty || key == shill::kErrorDetailsProperty) {
- log_level = network_event_log::LOG_LEVEL_ERROR;
+ log_level = device_event_log::LOG_LEVEL_ERROR;
} else {
- log_level = network_event_log::LOG_LEVEL_EVENT;
+ log_level = device_event_log::LOG_LEVEL_EVENT;
}
NET_LOG_LEVEL(log_level, log_event, detail);
}
@@ -599,7 +608,7 @@ void NetworkStateHandler::UpdateDeviceProperty(const std::string& device_path,
return;
std::string detail = device->name() + "." + key;
- detail += " = " + network_event_log::ValueAsString(value);
+ detail += " = " + ValueAsString(value);
NET_LOG_EVENT("DevicePropertyUpdated", detail);
NotifyDeviceListChanged();
« no previous file with comments | « chromeos/network/network_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698