Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 773653002: [Views] Instrument unmasking prompt initial implementation (Closed)

Created:
6 years ago by Evan Stade
Modified:
6 years ago
CC:
chromium-reviews, benquan, tfarina, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Views] Instrument unmasking prompt initial implementation depends on https://codereview.chromium.org/756333003/ BUG=437116 Committed: https://crrev.com/7b70d6a6549a569892445a503a00286c70700051 Cr-Commit-Position: refs/heads/master@{#307977}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : relative #

Patch Set 6 : remove android changes #

Total comments: 2

Patch Set 7 : merge #

Patch Set 8 : butterfingers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -2 lines) Patch
M chrome/browser/about_flags.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_view.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc View 1 2 3 4 5 6 7 1 chunk +159 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Evan Stade
6 years ago (2014-12-02 20:48:06 UTC) #2
please use gerrit instead
I haven't been able to find instrument_unmask_prompt_view.h in the tree. Has it been renamed? https://codereview.chromium.org/773653002/diff/100001/chrome/browser/ui/views/autofill/instrument_unmask_prompt_views.cc ...
6 years ago (2014-12-08 23:41:19 UTC) #3
please use gerrit instead
On 2014/12/08 23:41:19, Rouslan Solomakhin wrote: > I haven't been able to find instrument_unmask_prompt_view.h in ...
6 years ago (2014-12-08 23:41:49 UTC) #4
please use gerrit instead
LGTM % nit about "virtual" vs "override".
6 years ago (2014-12-08 23:42:11 UTC) #5
Evan Stade
https://codereview.chromium.org/773653002/diff/100001/chrome/browser/ui/views/autofill/instrument_unmask_prompt_views.cc File chrome/browser/ui/views/autofill/instrument_unmask_prompt_views.cc (right): https://codereview.chromium.org/773653002/diff/100001/chrome/browser/ui/views/autofill/instrument_unmask_prompt_views.cc#newcode37 chrome/browser/ui/views/autofill/instrument_unmask_prompt_views.cc:37: virtual ~InstrumentUnmaskPromptViews() { On 2014/12/08 23:41:19, Rouslan Solomakhin wrote: ...
6 years ago (2014-12-11 19:01:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773653002/140001
6 years ago (2014-12-11 19:58:36 UTC) #10
commit-bot: I haz the power
Committed patchset #8 (id:140001)
6 years ago (2014-12-11 21:11:30 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-11 23:08:43 UTC) #12
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/7b70d6a6549a569892445a503a00286c70700051
Cr-Commit-Position: refs/heads/master@{#307977}

Powered by Google App Engine
This is Rietveld 408576698