Convert sliced strings into sequential strings when promoting into old space.

test/cctest/test-strings.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 
 // Check that we can traverse very deep stacks of ConsStrings using
 // StringInputBuffer.  Check that Get(int) works on very deep stacks
 // of ConsStrings.  These operations may not be very fast, but they
 // should be possible without getting errors due to too deep recursion.
 
 #include <stdlib.h>
 
 #include "v8.h"
@@ skipping 511 matching lines @@
   CHECK(!string->IsSlicedString());
 
   string = FACTORY->NewSubString(string, 0, 26);
   CHECK(!string->IsSlicedString());
   result = CompileRun(crosscheck);
   CHECK(result->IsString());
   string = v8::Utils::OpenHandle(v8::String::Cast(*result));
   CHECK(string->IsSlicedString());
   CHECK_EQ("bcdefghijklmnopqrstuvwxy", *(string->ToCString()));
 }
+
+
+TEST(SliceConversion) {
+  // This tests whether a slice promoted during scavenging is properly
+  // converted to a sequential string when being copied into old space.
+  FLAG_string_slices = true;
+  InitializeVM();
+  HandleScope scope;
+  v8::Local<v8::Value> result;
+  Handle<String> string;
+  const char* init = "var str = 'abcdefghijklmnopqrstuvwxyz';";
+  const char* slice = "str.slice(2,24)";
+  const char* fill_new_space =
+      "var fill = [];"
+      "for (var i = 0; i < 100000; i++) fill.push(i + ' ');";
+
+
+  CompileRun(init);
+
+  result = CompileRun(slice);
+  CHECK(result->IsString());
+  string = v8::Utils::OpenHandle(v8::String::Cast(*result));
+  CHECK(HEAP->InNewSpace(*string));
+  CHECK(string->IsSlicedString());
+  CHECK_EQ("cdefghijklmnopqrstuvwx", *(string->ToCString()));
+
+  CompileRun(fill_new_space);
+  HEAP->PerformScavenge();
+
+  CHECK(!HEAP->InNewSpace(*string));
+  CHECK(string->IsSeqString());
+  CHECK_EQ("cdefghijklmnopqrstuvwx", *(string->ToCString()));
+}