Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 7736011: Port r9030 and part of r9016 to 3.3 branch. (Closed)

Created:
9 years, 3 months ago by Lasse Reichstein
Modified:
9 years, 3 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Port r9030 and part of r9016 to 3.3 branch. Made FromPropertyDescriptor not hit inherited setters. Changed computation of func.caller to skip some built-in functions. Now skips built-in functions called from other built-in functions, so only the initally called built-in function is exposed. Committed: http://code.google.com/p/v8/source/detail?r=9040

Patch Set 1 #

Patch Set 2 : Also prevent FromPropertyDescriptor from hitting inherited setters. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -42 lines) Patch
M src/accessors.cc View 2 chunks +67 lines, -30 lines 2 comments Download
M src/v8natives.js View 1 1 chunk +11 lines, -11 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/function-caller.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 3 months ago (2011-08-29 10:24:23 UTC) #1
Rico
LGTM http://codereview.chromium.org/7736011/diff/1004/src/accessors.cc File src/accessors.cc (right): http://codereview.chromium.org/7736011/diff/1004/src/accessors.cc#newcode690 src/accessors.cc:690: } Why no space between functions here?
9 years, 3 months ago (2011-08-29 10:35:52 UTC) #2
Lasse Reichstein
9 years, 3 months ago (2011-08-29 10:39:27 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698