Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: src/IceOperand.cpp

Issue 773583004: Subzero: Fix the g++ build (e.g. Windows). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceInst.h ('k') | src/PNaClTranslator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceOperand.cpp
diff --git a/src/IceOperand.cpp b/src/IceOperand.cpp
index d7ea10b6b6150c88a8f42ec87cead7676dc8a299..fc2a7caa0b91000c7798428c2365deec4657afe3 100644
--- a/src/IceOperand.cpp
+++ b/src/IceOperand.cpp
@@ -253,6 +253,7 @@ const Inst *VariableTracking::getFirstDefinition() const {
assert(FirstOrSingleDefinition);
return FirstOrSingleDefinition;
}
Karl 2014/12/04 21:58:15 nullptr?
Jim Stichnoth 2014/12/04 22:09:15 I actually meant to keep it NULL to be consistent
+ return NULL;
}
const Inst *VariableTracking::getSingleDefinition() const {
@@ -265,6 +266,7 @@ const Inst *VariableTracking::getSingleDefinition() const {
assert(FirstOrSingleDefinition);
return FirstOrSingleDefinition;
}
+ return NULL;
Karl 2014/12/04 21:58:15 nullptr?
}
void VariablesMetadata::init(MetadataKind TrackingKind) {
« no previous file with comments | « src/IceInst.h ('k') | src/PNaClTranslator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698