Index: components/autofill/content/renderer/autofill_agent.cc |
diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc |
index 8a9350e9304bc369045479377850335096a0421e..ade2d10f6bcea106c87f3e512d0e82b1a21a3973 100644 |
--- a/components/autofill/content/renderer/autofill_agent.cc |
+++ b/components/autofill/content/renderer/autofill_agent.cc |
@@ -242,7 +242,7 @@ void AutofillAgent::FocusedNodeChanged(const WebNode& node) { |
const WebInputElement* element = toWebInputElement(&web_element); |
if (!element || !element->isEnabled() || element->isReadOnly() || |
- !element->isTextField() || element->isPasswordField()) |
+ !element->isTextField()) |
return; |
element_ = *element; |
Ilya Sherman
2014/12/11 23:28:55
I honestly don't even remember why it's important
jww
2014/12/12 00:17:43
I think it's as simple as the focused node has cha
Ilya Sherman
2014/12/12 00:25:50
AcceptDataListSuggestion should only be called aft
jww
2014/12/12 00:54:55
My change doesn't touch the assignment of element_
Ilya Sherman
2014/12/12 01:56:02
I think you can still address my more narrow quest
jww
2014/12/12 02:05:49
Ah, got it. I misunderstood your request. Done.
|
@@ -610,7 +610,7 @@ void AutofillAgent::ShowSuggestions(const WebFormControlElement& element, |
const WebInputElement* input_element = toWebInputElement(&element); |
if (input_element) { |
- if (!input_element->isTextField() || input_element->isPasswordField()) |
+ if (!input_element->isTextField()) |
Ilya Sherman
2014/12/11 23:28:55
I am concerned that without the isPasswordField()
jww
2014/12/12 00:17:43
Good point. I moved the guard further down, right
|
return; |
if (!options.datalist_only && !input_element->suggestedValue().isEmpty()) |
return; |