Issue 773563002: Pre-cache local matrix type in shader constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 773563002: Pre-cache local matrix type in shader constructor. (Closed)

Created:
6 years ago by mtklein_C

Modified:
6 years ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Pre-cache local matrix type in shader constructor. TSAN points out we race when choosing our blitter without this. BUG=437511 Committed: https://skia.googlesource.com/skia/+/435eba7e1eb6f6622ebe171274a8d595d947a9cd

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/core/SkShader.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773563002/1

6 years ago (2014-12-01 19:55:58 UTC) #4

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

6 years ago (2014-12-01 19:55:58 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-01 20:06:27 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/435eba7e1eb6f6622ebe171274a8d595d947a9cd