Issue 773433003: Force SkMatrix type while recording too.

Issue 773433003: Force SkMatrix type while recording too. (Closed)

Created:
6 years ago by mtklein_C

Modified:
6 years ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Force SkMatrix type while recording too. This switches to a new way of doing this, enforcing the caching with the type recorded rather than having to do it in SkRecorder. Should be more foolproof. Updated SkPath and SkBitmap's equivalents too. ImmutableBitmap was close, but using inheritance now makes the rest of the code less weird. BUG=437511 I'm not sure whether or not this will _fix_ the SkMatrix aspect of that bug. There may be other SkMatrices that we're racing on. It does cover the obvious ones, though, and removing the SkTRacy<> wrapper will allow TSAN to show us any other races. It turned out to be easier to turn missing optional matrices into I early rather than late. I figure this should be harmless. Recording and playback perf both look neutral. Committed: https://skia.googlesource.com/skia/+/af57903f330a0afd0c10244d4a66f64fdbef5d1e

Patch Set 1 #

Patch Set 2 : bitmap too #

Patch Set 3 : unweird #

Patch Set 4 : no racy #

Patch Set 5 : rebase #

Patch Set 6 : rebase again #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -53 lines)			Patch
M	include/core/SkMatrix.h	View	1 2 3	2 chunks	+4 lines, -5 lines	0 comments	Download
M	src/core/SkRecordDraw.cpp	View	1 2	5 chunks	+9 lines, -13 lines	0 comments	Download
M	src/core/SkRecorder.cpp	View		5 chunks	+5 lines, -12 lines	0 comments	Download
M	src/core/SkRecords.h	View	1	5 chunks	+29 lines, -19 lines	0 comments	Download
M	src/gpu/GrRecordReplaceDraw.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download