Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 773433002: Add a base class for GrIODB that handles geometry data (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add a base class for GrIODB that handles geometry data Committed: https://skia.googlesource.com/skia/+/371bcbcb9fa7f9acba265de9de5dd23f62a64a86

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -331 lines) Patch
M gyp/gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
A src/gpu/GrFlushToGpuDrawTarget.h View 1 2 1 chunk +92 lines, -0 lines 0 comments Download
A src/gpu/GrFlushToGpuDrawTarget.cpp View 1 1 chunk +251 lines, -0 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 6 chunks +6 lines, -66 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 12 chunks +20 lines, -260 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bsalomon
6 years ago (2014-12-01 15:18:04 UTC) #2
joshualitt
LGTM. I read this assuming you didn't actually change any of the logic and just ...
6 years ago (2014-12-01 15:30:10 UTC) #3
bsalomon
On 2014/12/01 15:30:10, joshualitt wrote: > LGTM. I read this assuming you didn't actually change ...
6 years ago (2014-12-01 15:34:58 UTC) #4
joshualitt
On 2014/12/01 15:34:58, bsalomon wrote: > On 2014/12/01 15:30:10, joshualitt wrote: > > LGTM. I ...
6 years ago (2014-12-01 15:38:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773433002/40001
6 years ago (2014-12-01 16:09:00 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-01 16:19:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/371bcbcb9fa7f9acba265de9de5dd23f62a64a86

Powered by Google App Engine
This is Rietveld 408576698