Issue 77343005: When using C++11, use static_assert to implement COMPILE_ASSERT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 77343005: When using C++11, use static_assert to implement COMPILE_ASSERT (Closed)

Created:
7 years, 1 month ago by Mark Mentovai

Modified:
7 years, 1 month ago

Reviewers:
Nico

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

When using C++11, use static_assert to implement COMPILE_ASSERT. Tag COMPILE_ASSERT with ALLOW_UNUSED for non-C++11 GCC 4.8, which otherwise produces warnings under -Wunused-local-typedefs. That warning is currently disabled in Chromium (r194779), but the ultimate goal should be to enable that warning. BUG=321833 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236356

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : git cl try #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	base/basictypes.h	View	1 2	3 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm! Thanks, I wanted to do this for a while. Maybe file a bug for ...

7 years, 1 month ago (2013-11-20 23:56:36 UTC) #2

Mark Mentovai

7 years, 1 month ago (2013-11-21 00:51:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r236356 (presubmit successful).

Expand Messages | Collapse Messages