Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 773383002: Revert of NaCl: Update revision in DEPS, r14147 -> r14154 (Closed)

Created:
6 years ago by Lei Zhang
Modified:
6 years ago
CC:
chromium-reviews, bradn, Derek Schuff, David Yen, hamaji, jvoung - send to chromium..., native-client-reviews_googlegroups.com, petarj, bradnelson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl: Update revision in DEPS, r14147 -> r14154 (patchset #1 id:1 of https://codereview.chromium.org/774883002/) Reason for revert: Broke MSAN bots. Original issue's description: > NaCl: Update revision in DEPS, r14147 -> r14154 > > This pulls in the following Native Client changes: > > r14148: (dschuff) PNaCl: Update LLVM/clang/binutils-x86 revision in pnacl/COMPONENT_REVISIONS > r14149: (hamaji) Update revision for PNaCl r14144->r14148 > r14150: (petarj) Fix issue in DecodeEscaping() in debug_stub test > r14151: (mseaborn) Remove much of the unused parts of pnacl/build.sh > r14152: (bradnelson) Nest the pnacl section of untrusted.gypi to the same level. > r14153: (dyen) The cached results from toolchain_build should be deterministic. > r14154: (jvoung) Add options for base dir and redirecting files to IRT open resource and use it. > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk > > Committed: https://crrev.com/42eb0eef6896901103f03c37c7e1fdd6e87eac5e > Cr-Commit-Position: refs/heads/master@{#306727} TBR=dschuff@chromium.org,mseaborn@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/06c1b216dcc90b933ae3c89a29182bc6a6dea646 Cr-Commit-Position: refs/heads/master@{#306754}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
Created Revert of NaCl: Update revision in DEPS, r14147 -> r14154
6 years ago (2014-12-04 03:02:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773383002/1
6 years ago (2014-12-04 03:02:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-04 03:03:09 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/06c1b216dcc90b933ae3c89a29182bc6a6dea646 Cr-Commit-Position: refs/heads/master@{#306754}
6 years ago (2014-12-04 03:04:56 UTC) #4
Mark Seaborn
Please, when you revert a change, include more information than "Broke MSAN bots"! Can you ...
6 years ago (2014-12-04 21:57:39 UTC) #5
Lei Zhang
6 years ago (2014-12-04 22:01:28 UTC) #6
Message was sent while issue was closed.
On 2014/12/04 21:57:39, Mark Seaborn wrote:
> Please, when you revert a change, include more information than "Broke MSAN
> bots"!
> 
> Can you give a link to the failure you saw, and copy+paste the relevant part
> (since Buildbot URLs have limited lifetime), please?

I commented on the CL that was being reverted:
https://codereview.chromium.org/774883002/#msg16

I'll write a more detailed revert msg next time.

Powered by Google App Engine
This is Rietveld 408576698