Expose render_process_id to CastShellActivity.

Expose render_process_id to CastShellActivity.

Extend android classes to expose render_process_id for device
identification purposes. Also improve logging for client
certificate selection to expose the render_process_id associated
with the request.

R=gunsch@chromium.org

Change-Id: Iae853ff54c6969da85cb95b8adb14cb07c74695f

BUG=

Committed: https://crrev.com/3eccd967d6b5e276deb2ee655922b779b8146d6c
Cr-Commit-Position: refs/heads/master@{#306701}

[gunsch, 2014-12-03 19:54:11]

Note: "Android DeviceId fixes." isn't a very helpful CL description line. This
CL is largely about adding an API to get the current RenderProcessHost ID.

https://codereview.chromium.org/773313002/diff/1/chromecast/browser/android/a...
File
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java
(right):

https://codereview.chromium.org/773313002/diff/1/chromecast/browser/android/a...
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java:100:
public int getRenderProcessId(long pointerOfNativeCastWindow) {
I don't think this needs to go through CastWindowManager at all. Why not just
add an API on CastWindowAndroid directly?

[derekjchow1, 2014-12-03 21:33:30]

Issue updated.

https://codereview.chromium.org/773313002/diff/1/chromecast/browser/android/a...
File
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java
(right):

https://codereview.chromium.org/773313002/diff/1/chromecast/browser/android/a...
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowManager.java:100:
public int getRenderProcessId(long pointerOfNativeCastWindow) {
On 2014/12/03 19:54:11, gunsch wrote:
> I don't think this needs to go through CastWindowManager at all. Why not just
> add an API on CastWindowAndroid directly?

Done.

[gunsch, 2014-12-03 21:53:59]

lgtm % a few changes. feel free to submit after fixing

https://codereview.chromium.org/773313002/diff/20001/chromecast/browser/andro...
File
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java
(right):

https://codereview.chromium.org/773313002/diff/20001/chromecast/browser/andro...
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastShellActivity.java:207:
return mCastWindowManager.getActiveCastWindow().getRenderProcessId();
you can remove this method; the caller (subclass) can just use
getActiveCastWindow().getRenderProcessId()

https://codereview.chromium.org/773313002/diff/20001/chromecast/browser/andro...
File
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java
(right):

https://codereview.chromium.org/773313002/diff/20001/chromecast/browser/andro...
chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWindowAndroid.java:154:
mRenderProcessId = renderProcessId;
nit: move this towards the top of the method, since it's a simple setter of an
argument

[derekjchow1, 2014-12-03 22:17:07]

The CQ bit was checked by derekjchow@chromium.org

[commit-bot: I haz the power, 2014-12-03 22:18:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/773313002/40001

[commit-bot: I haz the power, 2014-12-03 22:58:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-03 22:58:56]

Patchset 3 (id:??) landed as
https://crrev.com/3eccd967d6b5e276deb2ee655922b779b8146d6c
Cr-Commit-Position: refs/heads/master@{#306701}