MacViews: Change TOOLKIT_VIEWS to !OS_MACOSX in extensions::WindowsEventRouter

MacViews: Change TOOLKIT_VIEWS to !OS_MACOSX in extensions::WindowsEventRouter

WindowsEventRouter needs to broadcast when no Chrome window has focus.

When toolkit_views first flips on Mac, nothing should actually change in
the release.

Until Chrome on Mac *only* makes Windows with toolkit-views,
WindowsEventRouter on Mac should still use
NSWindowDidBecomeKeyNotification + NOTIFICATION_NO_KEY_WINDOW.

This works both for windows created with toolkit-views and those created
natively.

BUG=439882
Committed: https://crrev.com/cf8643d40c475113c66f373416893493181b7dde
Cr-Commit-Position: refs/heads/master@{#308452}

[tapted, 2014-12-12 00:37:14]

Patchset #4 (id:60001) has been deleted

[tapted, 2014-12-12 00:37:21]

Patchset #3 (id:40001) has been deleted

[tapted, 2014-12-12 00:37:26]

Patchset #2 (id:20001) has been deleted

[tapted, 2014-12-12 00:37:32]

Patchset #1 (id:1) has been deleted

[tapted, 2014-12-12 01:51:00]

tapted@chromium.org changed reviewers:
+ kalman@chromium.org

[tapted, 2014-12-12 04:47:30]

Hi kalman, please take a look.

(I had a more adventurous refactor in patchset2, but since the eventual goal is
just to get rid of these ifdefs, I think the boring approach in patchset3 makes
the most sense).

[not at google - send to devlin, 2014-12-12 16:37:22]

This is largely over my head, but lgtm.

https://codereview.chromium.org/773303005/diff/120001/chrome/browser/extensio...
File chrome/browser/extensions/api/tabs/windows_event_router.cc (right):

https://codereview.chromium.org/773303005/diff/120001/chrome/browser/extensio...
chrome/browser/extensions/api/tabs/windows_event_router.cc:34: // currently
focused window. On Mac (event in a toolkit-views build) always
event -> even?

[tapted, 2014-12-15 22:20:45]

https://codereview.chromium.org/773303005/diff/120001/chrome/browser/extensio...
File chrome/browser/extensions/api/tabs/windows_event_router.cc (right):

https://codereview.chromium.org/773303005/diff/120001/chrome/browser/extensio...
chrome/browser/extensions/api/tabs/windows_event_router.cc:34: // currently
focused window. On Mac (event in a toolkit-views build) always
On 2014/12/12 16:37:22, kalman wrote:
> event -> even?

Whoops - Done.

[tapted, 2014-12-15 22:20:53]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-12-15 22:21:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/773303005/140001

[commit-bot: I haz the power, 2014-12-15 23:22:32]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2014-12-15 23:24:10]

Patchset 4 (id:??) landed as
https://crrev.com/cf8643d40c475113c66f373416893493181b7dde
Cr-Commit-Position: refs/heads/master@{#308452}