Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 773283006: Run gn format on all BUILD.gn files (gn version 306668) (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan, scottmg
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Run gn format on all BUILD.gn files (gn version 306668) Generated by running the following: for x in `git ls-files | grep BUILD.gn`; do gn format --in-place $x; done BUG=348474 R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8bcf28edb4fb6b5055f96cb0a8133284a1cc5db5

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1045 lines, -1096 lines) Patch
M BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M benchmarks/startup/BUILD.gn View 1 chunk +9 lines, -3 lines 2 comments Download
M examples/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M examples/apptest/BUILD.gn View 1 chunk +8 lines, -4 lines 0 comments Download
M examples/aura_demo/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M examples/content_handler_demo/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M examples/device_name/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M examples/echo/BUILD.gn View 3 chunks +10 lines, -4 lines 0 comments Download
M examples/http_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/indirect_service/BUILD.gn View 4 chunks +12 lines, -4 lines 0 comments Download
M examples/keyboard/BUILD.gn View 1 chunk +3 lines, -2 lines 0 comments Download
M examples/media_viewer/BUILD.gn View 1 chunk +19 lines, -21 lines 0 comments Download
M examples/nesting_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/pdf_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/png_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/recursive_content_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/sample_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M examples/wget/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/BUILD.gn View 3 chunks +7 lines, -21 lines 0 comments Download
M mojo/android/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/application_manager/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/converters/geometry/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/converters/input_events/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/converters/surfaces/tests/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/dart/BUILD.gn View 5 chunks +5 lines, -9 lines 0 comments Download
M mojo/dart/embedder/BUILD.gn View 3 chunks +29 lines, -18 lines 0 comments Download
M mojo/dart/embedder/test/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/embedder/BUILD.gn View 3 chunks +7 lines, -2 lines 0 comments Download
M mojo/edk/js/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/js/test/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/edk/js/tests/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/edk/test/BUILD.gn View 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/environment/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/go/BUILD.gn View 3 chunks +9 lines, -9 lines 0 comments Download
M mojo/public/BUILD.gn View 2 chunks +5 lines, -7 lines 0 comments Download
M mojo/public/c/environment/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/c/gles2/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/public/c/system/BUILD.gn View 1 chunk +15 lines, -5 lines 0 comments Download
M mojo/public/c/test_support/BUILD.gn View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 2 chunks +10 lines, -4 lines 0 comments Download
M mojo/public/cpp/application/tests/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/public/cpp/environment/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M mojo/public/cpp/system/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/public/dart/BUILD.gn View 4 chunks +6 lines, -10 lines 0 comments Download
M mojo/public/java/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/public/platform/native/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/sky/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/public/cpp/geometry/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/gpu/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 6 chunks +24 lines, -31 lines 0 comments Download
M mojo/shell/domain_socket/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M net/BUILD.gn View 2 chunks +10 lines, -14 lines 0 comments Download
M services/gles2/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M services/js/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/js/test/BUILD.gn View 1 chunk +6 lines, -3 lines 0 comments Download
M services/native_viewport/BUILD.gn View 3 chunks +7 lines, -8 lines 0 comments Download
M services/tracing/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M services/window_manager/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M sky/engine/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/BUILD.gn View 5 chunks +23 lines, -21 lines 0 comments Download
M sky/engine/bindings/core/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/BUILD.gn View 2 chunks +5 lines, -7 lines 0 comments Download
M sky/engine/bindings/scripts/BUILD.gn View 2 chunks +6 lines, -3 lines 0 comments Download
M sky/engine/core/BUILD.gn View 19 chunks +34 lines, -56 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 10 chunks +24 lines, -28 lines 0 comments Download
M sky/engine/v8_inspector/BUILD.gn View 4 chunks +14 lines, -8 lines 0 comments Download
M sky/engine/web/BUILD.gn View 5 chunks +9 lines, -6 lines 0 comments Download
M sky/engine/wtf/BUILD.gn View 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/iaccessible2/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/sqlite/BUILD.gn View 4 chunks +9 lines, -2 lines 0 comments Download
M ui/accessibility/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/android/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download
M ui/aura/BUILD.gn View 6 chunks +131 lines, -152 lines 0 comments Download
M ui/base/BUILD.gn View 11 chunks +160 lines, -197 lines 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +51 lines, -54 lines 0 comments Download
M ui/display/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M ui/events/BUILD.gn View 4 chunks +6 lines, -10 lines 0 comments Download
M ui/events/ipc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/BUILD.gn View 5 chunks +5 lines, -15 lines 0 comments Download
M ui/events/platform/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/gfx/BUILD.gn View 5 chunks +7 lines, -18 lines 0 comments Download
M ui/gfx/x/BUILD.gn View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/native_theme/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M ui/ozone/BUILD.gn View 5 chunks +33 lines, -32 lines 0 comments Download
M ui/ozone/platform/caca/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M ui/ozone/platform/dri/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download
M ui/ozone/platform/egltest/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/platform_window/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/platform_window/x11/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M ui/resources/BUILD.gn View 2 chunks +16 lines, -5 lines 0 comments Download
M ui/views/BUILD.gn View 3 chunks +109 lines, -110 lines 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +49 lines, -51 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jamesr
6 years ago (2014-12-04 01:36:22 UTC) #2
viettrungluu
Rubberstamp LGTM
6 years ago (2014-12-04 01:37:59 UTC) #3
jamesr
Committed patchset #1 (id:1) manually as 8bcf28edb4fb6b5055f96cb0a8133284a1cc5db5 (presubmit successful).
6 years ago (2014-12-04 01:39:55 UTC) #4
eseidel
<3
6 years ago (2014-12-05 16:54:10 UTC) #6
eseidel
https://codereview.chromium.org/773283006/diff/1/benchmarks/startup/BUILD.gn File benchmarks/startup/BUILD.gn (right): https://codereview.chromium.org/773283006/diff/1/benchmarks/startup/BUILD.gn#newcode20 benchmarks/startup/BUILD.gn:20: sources = [ Wonder why it does this? It ...
6 years ago (2014-12-05 16:55:42 UTC) #7
scottmg
6 years ago (2014-12-05 17:04:41 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/773283006/diff/1/benchmarks/startup/BUILD.gn
File benchmarks/startup/BUILD.gn (right):

https://codereview.chromium.org/773283006/diff/1/benchmarks/startup/BUILD.gn#...
benchmarks/startup/BUILD.gn:20: sources = [
On 2014/12/05 16:55:42, eseidel wrote:
> Wonder why it does this?  It seems to make other lists one line...

That's per the Brett style guide.
https://codereview.chromium.org/731923003/#msg5 (which ended up landing in
https://codereview.chromium.org/748863003 ). I'm generally ambivalent, but am
aware it can be a bit surprising that only certain variables get multiline
lists.

Powered by Google App Engine
This is Rietveld 408576698