Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 773253004: Move Syzygy build related things to their own directory with an OWNERS file, and add an allocation … (Closed)

Created:
6 years ago by chrisha
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move Syzygy build related things to their own directory with an OWNERS file, and add an allocation filter file. BUG= Committed: https://crrev.com/f25cab288d618105237ae2e9138cfe59d0cf42b2 Cr-Commit-Position: refs/heads/master@{#308637}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Small fix. #

Total comments: 2

Patch Set 4 : Fixed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -284 lines) Patch
M chrome/chrome_syzygy.gypi View 1 2 4 chunks +12 lines, -4 lines 0 comments Download
M chrome/tools/build/win/OWNERS View 1 chunk +0 lines, -8 lines 0 comments Download
A chrome/tools/build/win/syzygy/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A + chrome/tools/build/win/syzygy/instrument.py View 1 2 3 4 chunks +9 lines, -3 lines 0 comments Download
A + chrome/tools/build/win/syzygy/reorder.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/tools/build/win/syzygy/syzyasan-allocation-filter.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A + chrome/tools/build/win/syzygy/syzyasan-instrumentation-filter.txt View 1 chunk +1 line, -1 line 0 comments Download
D chrome/tools/build/win/syzygy_instrument.py View 1 chunk +0 lines, -146 lines 0 comments Download
D chrome/tools/build/win/syzygy_reorder.py View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/tools/build/win/win-syzyasan-filter.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M content/content_shell.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdf.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
chrisha
jam: OWNER for pdf. sebmarchand: Everything else. Mostly just code shuffling. PTAL?
6 years ago (2014-12-15 16:07:57 UTC) #2
Sébastien Marchand
lgtm ! https://codereview.chromium.org/773253004/diff/40001/chrome/tools/build/win/syzygy/instrument.py File chrome/tools/build/win/syzygy/instrument.py (right): https://codereview.chromium.org/773253004/diff/40001/chrome/tools/build/win/syzygy/instrument.py#newcode134 chrome/tools/build/win/syzygy/instrument.py:134: option_parser.add oops ?
6 years ago (2014-12-15 16:13:32 UTC) #3
chrisha
Fixed seb's nit. https://codereview.chromium.org/773253004/diff/40001/chrome/tools/build/win/syzygy/instrument.py File chrome/tools/build/win/syzygy/instrument.py (right): https://codereview.chromium.org/773253004/diff/40001/chrome/tools/build/win/syzygy/instrument.py#newcode134 chrome/tools/build/win/syzygy/instrument.py:134: option_parser.add On 2014/12/15 16:13:27, Sébastien Marchand ...
6 years ago (2014-12-15 16:17:28 UTC) #4
jam
lgtm
6 years ago (2014-12-15 19:20:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773253004/60001
6 years ago (2014-12-16 19:35:27 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-16 19:40:21 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-16 19:40:59 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/f25cab288d618105237ae2e9138cfe59d0cf42b2
Cr-Commit-Position: refs/heads/master@{#308637}

Powered by Google App Engine
This is Rietveld 408576698