Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 773203005: spatnav: Change the data type of distance from long long to double (Closed)

Created:
6 years ago by c.shu
Modified:
6 years ago
Reviewers:
Krzysztof Olczyk, fs
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

spatnav: Change the data type of distance from long long to double. 'double' makes more sense as it's computed as in the first place. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186612

Patch Set 1 #

Patch Set 2 : 2nd patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/page/SpatialNavigation.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
c.shu
6 years ago (2014-12-04 17:29:21 UTC) #2
tkent
6 years ago (2014-12-05 01:15:04 UTC) #4
fs
Yes, 'long long' is not a pleasant type... but neither is 'long' - how about ...
6 years ago (2014-12-05 09:50:36 UTC) #5
c.shu
On 2014/12/05 09:50:36, fs wrote: > Yes, 'long long' is not a pleasant type... but ...
6 years ago (2014-12-05 15:31:32 UTC) #6
fs
lgtm Please also change to the new subject in the description. (And i suggest SNAV->spatnav)
6 years ago (2014-12-05 15:42:51 UTC) #7
c.shu
On 2014/12/05 15:42:51, fs wrote: > lgtm > > Please also change to the new ...
6 years ago (2014-12-05 16:05:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773203005/20001
6 years ago (2014-12-05 16:05:53 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-05 17:53:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186612

Powered by Google App Engine
This is Rietveld 408576698