Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 773183003: Make Cronet's upload test server to serve files (Closed)

Created:
6 years ago by xunjieli
Modified:
6 years ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make Cronet's upload test server to serve files This CL added support for the upload test server to serve files. Files served by mock UrlRequest jobs can only be used by chromium net stack. By making the upload test server serve files, we can also test other clients. Committed: https://crrev.com/b3b912cec434b104934407998128a0d586a496f6 Cr-Commit-Position: refs/heads/master@{#306890}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlRequestTest.java View 1 chunk +16 lines, -0 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/cronet_test_apk/UploadTestServer.java View 2 chunks +5 lines, -0 lines 0 comments Download
M components/cronet/android/test/upload_test_server.cc View 1 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
mmenke
On 2014/12/03 19:09:18, xunjieli wrote: > mailto:xunjieli@chromium.org changed reviewers: > + mailto:mmenke@chromium.org Is this ready ...
6 years ago (2014-12-03 21:43:26 UTC) #2
xunjieli
On 2014/12/03 21:43:26, mmenke wrote: > On 2014/12/03 19:09:18, xunjieli wrote: > > mailto:xunjieli@chromium.org changed ...
6 years ago (2014-12-03 21:45:09 UTC) #3
xunjieli
6 years ago (2014-12-03 21:45:20 UTC) #4
mmenke
LGTM https://codereview.chromium.org/773183003/diff/1/components/cronet/android/test/upload_test_server.cc File components/cronet/android/test/upload_test_server.cc (right): https://codereview.chromium.org/773183003/diff/1/components/cronet/android/test/upload_test_server.cc#newcode91 components/cronet/android/test/upload_test_server.cc:91: g_test_server->ServeFilesFromDirectory(test_files_root); Think it's worth a comment that this ...
6 years ago (2014-12-04 20:29:13 UTC) #5
xunjieli
thanks! https://codereview.chromium.org/773183003/diff/1/components/cronet/android/test/upload_test_server.cc File components/cronet/android/test/upload_test_server.cc (right): https://codereview.chromium.org/773183003/diff/1/components/cronet/android/test/upload_test_server.cc#newcode91 components/cronet/android/test/upload_test_server.cc:91: g_test_server->ServeFilesFromDirectory(test_files_root); On 2014/12/04 20:29:13, mmenke wrote: > Think ...
6 years ago (2014-12-04 20:37:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773183003/20001
6 years ago (2014-12-04 20:37:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-04 21:16:36 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-04 21:18:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3b912cec434b104934407998128a0d586a496f6
Cr-Commit-Position: refs/heads/master@{#306890}

Powered by Google App Engine
This is Rietveld 408576698