Issue 773173002: Have PingLoader gracefully self-dispose.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 773173002: Have PingLoader gracefully self-dispose. (Closed)

Created:
6 years ago by sof

Modified:
6 years ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Have PingLoader gracefully self-dispose. Follow up on r186373 and correctly dispose of a running PingLoader once it gets a notification indicating that the ping transmission has completed. We want to cancel loading at that point. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186420

Patch Set 1 #

Patch Set 2 : clear m_loader on initial cancellation #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -5 lines)			Patch
	M	Source/core/loader/PingLoader.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	Source/core/loader/PingLoader.cpp	View	1	6 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

Please take a look. Some crashers on trunk, https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan__dbg_/7692/layout-test-results/results.html

6 years ago (2014-12-03 11:49:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773173002/20001

6 years ago (2014-12-03 13:33:13 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-03 14:16:48 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186420

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages