Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 773133009: Introduce new API Language() to test lang attribute that is properly reported. (Closed)

Created:
6 years ago by k.czech
Modified:
6 years ago
Reviewers:
dmazzoni
CC:
dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Introduce new API Language() to test lang attribute that is properly reported. Added required methods to test it. BUG=none Committed: https://crrev.com/56dbaa5e9a53444a27051b047744efa94eb379e6 Cr-Commit-Position: refs/heads/master@{#307250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/shell/renderer/test_runner/web_ax_object_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
k.czech
6 years ago (2014-12-04 12:14:48 UTC) #1
dmazzoni
lgtm
6 years ago (2014-12-04 16:28:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773133009/1
6 years ago (2014-12-05 09:46:37 UTC) #5
k.czech
Stopped landing this patch, the whole feature is not complete.
6 years ago (2014-12-05 10:04:11 UTC) #7
k.czech
On 2014/12/05 10:04:11, k.czech wrote: > Stopped landing this patch, the whole feature is not ...
6 years ago (2014-12-08 11:52:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773133009/1
6 years ago (2014-12-08 11:53:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773133009/1
6 years ago (2014-12-08 11:56:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773133009/1
6 years ago (2014-12-08 15:43:12 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-08 15:44:02 UTC) #17
commit-bot: I haz the power
6 years ago (2014-12-08 15:44:59 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56dbaa5e9a53444a27051b047744efa94eb379e6
Cr-Commit-Position: refs/heads/master@{#307250}

Powered by Google App Engine
This is Rietveld 408576698