Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 773123002: 'Search Google for ...' menu item is not coming for selected text in extension panel. (Closed)

Created:
6 years ago by Deepak
Modified:
6 years ago
Reviewers:
lazyboy, ankitkumar
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

'Search Google for ...' menu item is not coming for selected text in extension panel. Case for Search Provider was not present. Case added for Search Provider for extension panel. BUG=438488 Committed: https://crrev.com/ba5aa8901531959db61e8b854a5761c970a9bfe4 Cr-Commit-Position: refs/heads/master@{#306989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/renderer_context_menu/context_menu_content_type_panel.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Deepak
PTAL.
6 years ago (2014-12-03 04:34:37 UTC) #2
Deepak
On 2014/12/03 04:34:37, Deepak wrote: PTAL.
6 years ago (2014-12-05 02:46:49 UTC) #3
lazyboy
LGTM
6 years ago (2014-12-05 04:23:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773123002/1
6 years ago (2014-12-05 04:32:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-05 06:07:22 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-05 06:08:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba5aa8901531959db61e8b854a5761c970a9bfe4
Cr-Commit-Position: refs/heads/master@{#306989}

Powered by Google App Engine
This is Rietveld 408576698