Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3129)

Unified Diff: chrome/browser/history/history_unittest.cc

Issue 773103004: Remove NOTIFICATION_HISTORY_URLS_DELETED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to tip Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_service.cc ('k') | chrome/browser/history/in_memory_history_backend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_unittest.cc
diff --git a/chrome/browser/history/history_unittest.cc b/chrome/browser/history/history_unittest.cc
index e30a9b87300ecc2054407ec84fc861681d549e94..3daf4ac01be90dc6806c5bcb6dda054bee4a50a9 100644
--- a/chrome/browser/history/history_unittest.cc
+++ b/chrome/browser/history/history_unittest.cc
@@ -43,7 +43,6 @@
#include "base/threading/platform_thread.h"
#include "base/time/time.h"
#include "chrome/browser/history/history_backend.h"
-#include "chrome/browser/history/history_notifications.h"
#include "chrome/browser/history/history_service.h"
#include "chrome/browser/history/in_memory_history_backend.h"
#include "chrome/common/chrome_constants.h"
@@ -108,12 +107,14 @@ class BackendDelegate : public HistoryBackend::Delegate {
const RedirectList& redirects,
base::Time visit_time) override {}
void NotifyURLsModified(const URLRows& changed_urls) override {}
+ void NotifyURLsDeleted(bool all_history,
+ bool expired,
+ const URLRows& deleted_rows,
+ const std::set<GURL>& favicon_urls) override {}
void NotifyKeywordSearchTermUpdated(const URLRow& row,
KeywordID keyword_id,
const base::string16& term) override {}
void NotifyKeywordSearchTermDeleted(URLID url_id) override {}
- void BroadcastNotifications(int type,
- scoped_ptr<HistoryDetails> details) override;
void DBLoaded() override {}
private:
@@ -234,16 +235,6 @@ void BackendDelegate::SetInMemoryBackend(
history_test_->in_mem_backend_.swap(backend);
}
-void BackendDelegate::BroadcastNotifications(
- int type,
- scoped_ptr<HistoryDetails> details) {
- // Currently, just send the notifications directly to the in-memory database.
- // We may want do do something more fancy in the future.
- content::Details<HistoryDetails> det(details.get());
- history_test_->in_mem_backend_->Observe(type,
- content::Source<HistoryBackendDBTest>(NULL), det);
-}
-
TEST_F(HistoryBackendDBTest, ClearBrowsingData_Downloads) {
CreateBackendAndDatabase();
« no previous file with comments | « chrome/browser/history/history_service.cc ('k') | chrome/browser/history/in_memory_history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698