Remove NOTIFICATION_HISTORY_URLS_DELETED

components/history/core/browser/history_backend_observer.h

Index: components/history/core/browser/history_backend_observer.h
diff --git a/components/history/core/browser/history_backend_observer.h b/components/history/core/browser/history_backend_observer.h
index 0d537b2758ba9a76dc7cfa65c45696bff47a04bb..ae465e8e5c34dd6a28a1df73fcaa87df8ba155e4 100644
--- a/components/history/core/browser/history_backend_observer.h
+++ b/components/history/core/browser/history_backend_observer.h
@@ -11,6 +11,7 @@
 namespace history {
 
 class HistoryBackend;
+struct URLsDeletedDetails;
 
 class HistoryBackendObserver {
  public:
@@ -38,6 +39,13 @@ class HistoryBackendObserver {
   virtual void OnURLsModified(history::HistoryBackend* history_backend,
                               const history::URLRows& changed_urls) = 0;
 
+  // Called when one or more of URLs are deleted.
+  //
+  // |deleted_details| lists the URLs deleted from the history databse.
+  virtual void OnURLsDeleted(

[sdefresne, 2014/12/04 17:21:13]

So, looking at the calling site of the
chrome::NOTIFICATION_HISTORY_URLS_DELETED, if all_history is set to true, both
expired and deleted_rows are ignored, so we can either have two methods:

virtual void OnAllURLsDeleted(HistoryBackend* history_backend) = 0;
virtual void OnURLsDeleted(HistoryBackend* history_backend,
                           bool expired,
                           const URLRows& deleted_rows) = 0;

If you think this is too much work, I'd like to have at least the method not use
URLsDeletedDetails and instead be defined as below with a comment stating that
if all_history is true, the two other parameters are undefined:

virtual void OnURLsDeleted(HistoryBackend* history_backend,
                           bool all_history,
                           bool expired,
                           const URLRows& deleted_rows) = 0;

[nshaik, 2014/12/04 18:37:08]

Should I remove the |favicon_urls| and also remove it from
HistoryBackendNotifier?

+      HistoryBackend* history_backend,
+      const history::URLsDeletedDetails& deleted_details) = 0;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(HistoryBackendObserver);
 };