chrome/browser/history/android/android_provider_backend_unittest.cc - Issue 773103004: Remove NOTIFICATION_HISTORY_URLS_DELETED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/android_provider_backend_unittest.cc

Issue 773103004: Remove NOTIFICATION_HISTORY_URLS_DELETED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove NotificationObserver from InMemoryURLIndex Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/history/history_api.cc ('K') | « chrome/browser/extensions/api/history/history_api.cc ('k') | chrome/browser/history/history_backend.h » ('j') | chrome/browser/history/history_backend.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/android/android_provider_backend_unittest.cc

diff --git a/chrome/browser/history/android/android_provider_backend_unittest.cc b/chrome/browser/history/android/android_provider_backend_unittest.cc

index 6c19eafcbf8caa2b189181555a6e850bf6f1084e..2ca60c7682de59008ab9f349a17a80137b87b3f9 100644

--- a/chrome/browser/history/android/android_provider_backend_unittest.cc

+++ b/chrome/browser/history/android/android_provider_backend_unittest.cc

@@ -84,13 +84,13 @@ class AndroidProviderBackendDelegate : public HistoryBackend::Delegate {

void NotifyURLsModified(const history::URLRows& rows) override {

modified_details_.reset(new history::URLRows(rows));

}

+ void NotifyURLsDeleted(

+ const history::URLsDeletedDetails& urls_deleted_details) override {

+ deleted_details_.reset(new history::URLRows(urls_deleted_details.rows));

+ }

void BroadcastNotifications(

int type,

scoped_ptr<HistoryDetails> details) override {

- DCHECK_EQ(type, chrome::NOTIFICATION_HISTORY_URLS_DELETED);

sdefresne 2014/12/04 17:21:12 nit: NOTREACHED();

nshaik 2014/12/07 09:34:49 Done.

- scoped_ptr<URLsDeletedDetails> urls_deleted_details(

- static_cast<URLsDeletedDetails*>(details.release()));

- deleted_details_.reset(new history::URLRows(urls_deleted_details->rows));

}

void DBLoaded() override {}