Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2267)

Unified Diff: chrome/browser/history/expire_history_backend_unittest.cc

Issue 773103004: Remove NOTIFICATION_HISTORY_URLS_DELETED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/expire_history_backend_unittest.cc
diff --git a/chrome/browser/history/expire_history_backend_unittest.cc b/chrome/browser/history/expire_history_backend_unittest.cc
index 29b9d436c5578da2eef830215a5888c293a817ff..a70731c38e52a4d9aa18d404fcedb9308faab004 100644
--- a/chrome/browser/history/expire_history_backend_unittest.cc
+++ b/chrome/browser/history/expire_history_backend_unittest.cc
@@ -79,7 +79,6 @@ class ExpireHistoryTest : public testing::Test,
// Clears the list of notifications received.
void ClearLastNotifications() {
- STLDeleteValues(&notifications_);
urls_modified_notifications_.clear();
urls_deleted_notifications_.clear();
}
@@ -110,13 +109,6 @@ class ExpireHistoryTest : public testing::Test,
// Time at the beginning of the test, so everybody agrees what "now" is.
const Time now_;
- // Notifications intended to be broadcast, we can check these values to make
- // sure that the deletor is doing the correct broadcasts. We own the details
- // pointers.
- typedef std::vector< std::pair<int, HistoryDetails*> >
- NotificationList;
- NotificationList notifications_;
-
typedef std::vector<URLRows> URLsModifiedNotificationList;
URLsModifiedNotificationList urls_modified_notifications_;

Powered by Google App Engine
This is Rietveld 408576698